Merged
Conversation
spackbot-app
bot
added
dependencies
update-package
core
stephenswat
approved these changes
Mar 29, 2025
Member
|
@spackbot run pipeline |
|
I've started that pipeline for you! |
wdconinc
force-pushed
the
packages/geomodel-c
branch
from
1dc9dba to
1d76c60
Compare
Contributor
Author
|
Rebased and conflicts resolved. |
Member
|
It seems this one pulls in |
Contributor
Author
Probably should be virtualgl instead.
|
Contributor
|
FYI. You need to rebase to pick up the recently merged |
tldahlgren
requested changes
Apr 23, 2025
Contributor
tldahlgren
left a comment
tldahlgren
left a comment
There was a problem hiding this comment.
Minor nit about removing # generated comments from language dependencies. Also, you'll want to rebase to pick up the py-pillow fix.
wdconinc
force-pushed
the
packages/geomodel-c
branch
from
4213ec1 to
192bed5
Compare
danielsjensen1
added a commit
to danielsjensen1/spack
that referenced
this pull request
Apr 26, 2025
* develop: (752 commits) mesa: add v23.3.3 and use py-packaging while python>=3.12 (spack#49121) gcc: add v15.1.0 (spack#50212) draco: add v7.20.0 (spack#49996) sgpp: update dependencies and variants (spack#49384) input_analysis.py: fix conditional requirements (spack#50194) boost: add 1.88.0 (spack#50158) mapl: add v2.55.1 (spack#50201) mepo: add v2.3.2 (spack#50202) py-repligit: add v0.1.1 (spack#50204) [package updates] Bump version of cp2k and sirius (spack#50141) petsc4py: update ldshared.patch for v3.20.1, and skip for v3.23.1+ (spack#50170) namd: add v3.0.1 (spack#50192) geomodel: depend on c (spack#49781) CompilerAdaptor: add support for opt_flags/debug_flags (spack#50126) Add ls alias to spack {compiler, external} (spack#50189) covfie: depend on c (spack#50190) lua-sol2: add v3.5.0 (spack#49970) crtm-fix: fix directory logic (spack#50172) py-build: add v1.2.2 (spack#50148) py-pillow: fix build (spack#50177) ...
teaguesterling
pushed a commit
to teaguesterling/spack
that referenced
this pull request
May 20, 2025
* geomodel: depend on c * hep: add geomodel * hep: geomodel +fullsimlight * geomodel: depends on virtual gl, not opengl * soqt: depends on gl and glu instead of opengl * geomodel: rm generated comments on language dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures that
geomodelgets a C compiler.Due to e.g. https://gitlab.cern.ch/GeoModelDev/GeoModel/-/blob/main/GeoModelVisualization/CMakeLists.txt?ref_type=heads#L7. @stephenmsachs I can't file upstream PRs but this is an avoidable dependency. There are also other occurrences in the FSL plugins and examples. I'm going to require a C compiler for all cases rather than figuring out which combination exactly requires it.