Skip to content

url_fetch_method: allow curl args when selecting curl#49712

Merged
kwryankrattiger merged 1 commit intodevelopfrom
feature/curl-flags
Apr 1, 2025
Merged

url_fetch_method: allow curl args when selecting curl#49712
kwryankrattiger merged 1 commit intodevelopfrom
feature/curl-flags

Conversation

@becker33
Copy link
Copy Markdown
Member

Fixes #69

This PR expands the scope of the url_fetch_method config value, allowing users to specify curl arguments when selecting curl. E.g.

config:
  url_fetch_method: 'curl -k -q'

These arguments will be the first ones passed to curl, before the arguments Spack uses to control curl behavior.

PR includes unit test and docs.

@spackbot-app spackbot-app bot added core PR affects Spack core functionality documentation Improvements or additions to documentation fetching tests General test capability(ies) utilities labels Mar 27, 2025
Copy link
Copy Markdown
Contributor

@kwryankrattiger kwryankrattiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to issue with this, will approve later if no one else comments.

@kwryankrattiger kwryankrattiger merged commit ca64050 into develop Apr 1, 2025
37 of 38 checks passed
@kwryankrattiger kwryankrattiger deleted the feature/curl-flags branch April 1, 2025 20:23
climbfuji pushed a commit to climbfuji/spack that referenced this pull request Apr 17, 2025
tldahlgren added a commit to tldahlgren/spack that referenced this pull request Nov 11, 2025
The default was lost with the change in PR spack#49712.

Signed-off-by: tldahlgren <[email protected]>
tldahlgren added a commit to tldahlgren/spack that referenced this pull request Nov 14, 2025
The default was lost with the change in PR spack#49712.

Signed-off-by: tldahlgren <[email protected]>
tldahlgren added a commit to tldahlgren/spack that referenced this pull request Nov 14, 2025
The default was lost with the change in PR spack#49712.

Signed-off-by: tldahlgren <[email protected]>
tldahlgren added a commit to tldahlgren/spack that referenced this pull request Dec 1, 2025
The default was lost with the change in PR spack#49712.

Signed-off-by: tldahlgren <[email protected]>
tldahlgren added a commit to tldahlgren/spack that referenced this pull request Dec 3, 2025
The default was lost with the change in PR spack#49712.

Signed-off-by: tldahlgren <[email protected]>
tldahlgren added a commit to tldahlgren/spack that referenced this pull request Dec 3, 2025
The default was lost with the change in PR spack#49712.

Signed-off-by: tldahlgren <[email protected]>
tldahlgren added a commit to tldahlgren/spack that referenced this pull request Dec 4, 2025
The default was lost with the change in PR spack#49712.

Signed-off-by: tldahlgren <[email protected]>
tldahlgren added a commit to tldahlgren/spack that referenced this pull request Dec 8, 2025
The default was lost with the change in PR spack#49712.

Signed-off-by: tldahlgren <[email protected]>
tldahlgren added a commit to tldahlgren/spack that referenced this pull request Dec 10, 2025
The default was lost with the change in PR spack#49712.

Signed-off-by: tldahlgren <[email protected]>
tldahlgren added a commit to tldahlgren/spack that referenced this pull request Dec 10, 2025
The default was lost with the change in PR spack#49712.

Signed-off-by: tldahlgren <[email protected]>
tldahlgren added a commit to tldahlgren/spack that referenced this pull request Dec 12, 2025
The default was lost with the change in PR spack#49712.

Signed-off-by: tldahlgren <[email protected]>
tldahlgren added a commit to tldahlgren/spack that referenced this pull request Dec 12, 2025
The default was lost with the change in PR spack#49712.

Signed-off-by: tldahlgren <[email protected]>
tldahlgren added a commit to tldahlgren/spack that referenced this pull request Dec 17, 2025
The default was lost with the change in PR spack#49712.

Signed-off-by: tldahlgren <[email protected]>
tldahlgren added a commit to tldahlgren/spack that referenced this pull request Jan 6, 2026
The default was lost with the change in PR spack#49712.

Signed-off-by: tldahlgren <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core PR affects Spack core functionality documentation Improvements or additions to documentation fetching tests General test capability(ies) utilities

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Configuration options for curl arguments

2 participants