crtm: disable testing if not self.run_tests#49469
Merged
tldahlgren merged 2 commits intospack:developfrom Mar 14, 2025
Merged
Conversation
spackbot-app
bot
requested review from
Hang-Lei-NOAA,
climbfuji,
edwardhartnett and
t-brown
|
@BenjaminTJohnson can you review this PR? This PR modifies the following package(s), for which you are listed as a maintainer:
|
Contributor
Author
|
@spackbot fix style |
|
Let me see if I can fix that for you! |
|
I was able to run spack style --fix==> Running style checks on spack
selected: import, isort, black, flake8, mypy
==> Modified files
var/spack/repos/builtin/packages/crtm/package.py
==> Running import checks
import checks were clean
==> Running isort checks
isort checks were clean
==> Running black checks
All done! ✨ 🍰 ✨
1 file left unchanged.
black checks were clean
==> Running flake8 checks
var/spack/repos/builtin/packages/crtm/package.py:103: [W605] invalid escape sequence '\('
var/spack/repos/builtin/packages/crtm/package.py:103: [W605] invalid escape sequence '\)'
flake8 found errors
==> Running mypy checks
Success: no issues found in 640 source files
mypy checks were clean
I wasn't able to make any further changes, but please see the message above for remaining issues you can fix locally! |
tldahlgren
approved these changes
Mar 13, 2025
climbfuji
approved these changes
Mar 13, 2025
AlexanderRichert-NOAA
added a commit
to AlexanderRichert-NOAA/spack
that referenced
this pull request
Mar 14, 2025
* crtm: disable testing if not self.run_tests * Update package.py
AlexanderRichert-NOAA
added a commit
to JCSDA/spack
that referenced
this pull request
Mar 20, 2025
crtm: disable testing if not self.run_tests (spack#49469)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR conditionallty disables testing (based on self.run_tests) in CRTM, which based on the CMake config always happens, and downloads massive files, to boot.
This will be resolved (with -DBUILD_TESTING) in a future release: JCSDA/CRTMv3#211