Spec to string: show %compiler at the end#49439
Merged
Conversation
spackbot-app
bot
added
commands
core
MakisH
approved these changes
Mar 12, 2025
Contributor
MakisH
left a comment
MakisH
left a comment
There was a problem hiding this comment.
I have been tagged in this as maintainer of of-precice. The changes there look fine. Thanks!
haampie
force-pushed
the
hs/fix/default-spec-str-reorder-compiler
branch
from
4e792f1 to
7238f0b
Compare
alalazo
approved these changes
Mar 12, 2025
Member
alalazo
left a comment
alalazo
left a comment
There was a problem hiding this comment.
LGTM. I'll double check if there's any other reference to %compiler etc.
alalazo
requested changes
Mar 12, 2025
Member
There was a problem hiding this comment.
I think I found two other places that might need to be updated, for consistency:
spack/lib/spack/spack/cmd/help.py
Line 76 in cd3068d
spack/lib/spack/spack/environment/depfile.py
Line 169 in cd3068d
haampie
force-pushed
the
hs/fix/default-spec-str-reorder-compiler
branch
from
0037f84 to
6147368
Compare
alalazo
approved these changes
Mar 12, 2025
kjrstory
approved these changes
Mar 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: #44379
We used to format specs as
pkg%[email protected] +foo+bar ^dep +baz.This PR changes it to
pkg +foo+bar %[email protected] ^dep +baz.