Move %compiler last in static spec strings#49438
Merged
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
spackbot-app
bot
requested review from
AmintorDusko,
adamjstewart,
alalazo,
albestro,
aurianer,
climbfuji,
corbett5,
eirrgang,
elliottslaughter,
gheber,
meyersbs,
mtaillefumier,
scheibelp,
vincentmr and
williamfgc
This comment was marked as off-topic.
This comment was marked as off-topic.
spackbot-app
bot
added
conflicts
core
adamjstewart
approved these changes
Mar 12, 2025
Member
adamjstewart
left a comment
adamjstewart
left a comment
There was a problem hiding this comment.
py-* and xgboost changes look good to me. I'm not really affected by backwards-incompatible changes, but I'm sure someone would find the proposed changes to % controversial.
climbfuji
approved these changes
Mar 12, 2025
Contributor
|
|
alalazo
approved these changes
Mar 12, 2025
Member
|
Gitlab failures are all unrelated. For reference the pipelines are: https://gitlab.spack.io/spack/spack/-/pipelines/1010868 I'm force merging, since pipelines are ❌ on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: #44379
This moves
%compilerand%compiler@...after variants, arch, versions in all static spec strings in the Spack codebase.The reason for this is that
%will change meaning in Spack v1.0 from "compiler attribute" to "direct dependency". Currently in a spec stringpkg %gcc +featurethe+featurevariant refers topkg, in the future it will refer togcc. It mirrors what we're used to frompkg ^dep +feature.This PR was generated by parsing all string constants as specs from
*.pyfiles*.yml,*.yaml,*.jsonfilesDynamically created spec strings are not caught.