path and remote_file_cache: support windows paths#49437
Merged
scheibelp merged 2 commits intospack:developfrom Mar 12, 2025
Merged
path and remote_file_cache: support windows paths#49437scheibelp merged 2 commits intospack:developfrom
scheibelp merged 2 commits intospack:developfrom
Conversation
spackbot-app
bot
added
core
johnwparent
reviewed
Mar 12, 2025
Contributor
johnwparent
left a comment
johnwparent
left a comment
There was a problem hiding this comment.
Left a few comments. I think a lot of the logic in util.path can be removed, but as this is blocking develop, if it fixes CI, and doesn't fail the unit tests, I'd rather just merge this ASAP and cleanup in a subsequent PR, which is why this is a comment and not a change request.
johnwparent
reviewed
Mar 12, 2025
johnwparent
reviewed
Mar 12, 2025
Contributor
|
Thanks for this PR @tldahlgren, I really like the check for drive, add to file scheme trick. |
Contributor
Author
|
BTW (Not having a windows box atm) I am confused as to where the |
tldahlgren
commented
Mar 12, 2025
tldahlgren
force-pushed
the
url_path_windows_aware
branch
from
0049f08 to
82be1da
Compare
scheibelp
approved these changes
Mar 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR restores/adds support for Windows paths (with drives except drive-relative) (post-#48784) to
spack.util.path.canonicalize_path()andspack.util.remote_file_cache.local_path(). It also adds unit tests for both methods.