Fix assumption of linux platform in py-tensorflow#49425
Merged
adamjstewart merged 1 commit intospack:developfrom Mar 12, 2025
Merged
Fix assumption of linux platform in py-tensorflow#49425adamjstewart merged 1 commit intospack:developfrom
adamjstewart merged 1 commit intospack:developfrom
Conversation
post_configure_fixes assumed py-tensorflow depends on patchelf, but that dependency is platform dependent.
adamjstewart
approved these changes
Mar 12, 2025
Member
adamjstewart
left a comment
adamjstewart
left a comment
There was a problem hiding this comment.
Good catch! I would love to get bazel/TF working in macOS CI to prevent these kinds of issues. Let me know if you have any interest/expertise in debugging bazel codesigning issues.
Contributor
Author
|
Regretfully (or perhaps fortunately?) I have tried very hard not to have to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
post_configure_fixes assumed py-tensorflow depends on patchelf, but that dependency is platform dependent.