Fix: tensorflow empty config vars#49424
Merged
adamjstewart merged 3 commits intospack:developfrom Mar 12, 2025
Merged
Conversation
Contributor
Author
|
@spackbot fix style |
|
Let me see if I can fix that for you! |
|
I was able to run spack style --fix==> Running style checks on spack
selected: import, isort, black, flake8, mypy
==> Modified files
var/spack/repos/builtin/packages/py-tensorflow/package.py
==> Running import checks
import checks were clean
==> Running isort checks
isort checks were clean
==> Running black checks
reformatted var/spack/repos/builtin/packages/py-tensorflow/package.py
All done! ✨ 🍰 ✨
1 file reformatted.
black checks were clean
==> Running flake8 checks
flake8 checks were clean
==> Running mypy checks
Success: no issues found in 640 source files
mypy checks were clean
==> spack style checks were clean
I've updated the branch with style fixes. |
adamjstewart
approved these changes
Mar 12, 2025
Member
adamjstewart
left a comment
adamjstewart
left a comment
There was a problem hiding this comment.
Thanks for the fix! Can you accept the CLA for your TF PR?
Contributor
Author
|
As far as I can tell, I did, but it doesn’t seem to have retriggered the CI
bot. Will check again today.
--
Thomas Dickerson, Ph.D
Founder // Chief Science Officer
Geopipe, Inc.
802-458-0637
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if Spack decides CC_OPT_FLAGS should be empty, this incorrectly drops Tensorflow's
./configure.pyinto interactive mode. Fix allows Tensorflow to distinguish between empty and not set.Incidentally this patch is also pending at tensorflow/tensorflow#89032 so we can set an upper bound in package.py if that ever makes it into a release.