Skip to content

postgresql: add missing perl build dependency#49417

Merged
wdconinc merged 1 commit intospack:developfrom
michaelkuhn:postgresql-perl-build
Mar 11, 2025
Merged

postgresql: add missing perl build dependency#49417
wdconinc merged 1 commit intospack:developfrom
michaelkuhn:postgresql-perl-build

Conversation

@michaelkuhn
Copy link
Copy Markdown
Member

Without it, the build fails with errors like this:

Can't locate File/Compare.pm in @INC (you may need to install the File::Compare module) (@INC contains: ...) at ../../../src/backend/catalog/Catalog.pm line 19.

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Mar 11, 2025

Hi @michaelkuhn! I noticed that the following package(s) don't yet have maintainers:

  • postgresql

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers("michaelkuhn")

If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with spack blame:

$ spack blame postgresql

Thank you for your help! Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

@RobertMaaskant
Copy link
Copy Markdown
Contributor

If I read the docs correctly, it is only required for version 17 and optional for version <= 16. See https://www.postgresql.org/docs/17/install-requirements.html.

Without it, the build fails with errors like this:
```
Can't locate File/Compare.pm in @inc (you may need to install the File::Compare module) (@inc contains: ...) at ../../../src/backend/catalog/Catalog.pm line 19.
```
@michaelkuhn michaelkuhn force-pushed the postgresql-perl-build branch from a091189 to 93f856d Compare March 11, 2025 14:54
@michaelkuhn
Copy link
Copy Markdown
Member Author

If I read the docs correctly, it is only required for version 17 and optional for version <= 16. See https://www.postgresql.org/docs/17/install-requirements.html.

Thanks for the hint, I hadn't noticed that. flex and bison also seem to be build dependencies, so I have updated all three.

Copy link
Copy Markdown
Contributor

@wdconinc wdconinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix and review. This looks good to me, and builds fine in CI (though that's clearly not an indicator of necessity, considering that postgresql built fine in CI before as well...)

@wdconinc wdconinc merged commit ba4fd64 into spack:develop Mar 11, 2025
16 checks passed
@wdconinc wdconinc self-assigned this Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants