Skip to content

sgpp: update dependencies and variants#49384

Merged
msimberg merged 7 commits intospack:developfrom
G-071:sgpp-update-dependencies-and-variants
Apr 25, 2025
Merged

sgpp: update dependencies and variants#49384
msimberg merged 7 commits intospack:developfrom
G-071:sgpp-update-dependencies-and-variants

Conversation

@G-071
Copy link
Copy Markdown
Contributor

@G-071 G-071 commented Mar 8, 2025

This PR contains a couple of changes for the SGpp package:

  • SGpp master now works with modern Python/NumPy/Swig versions, requiring a change in the constraints of the Spack package.
  • Spack package is now also used for internal SGpp development. Hence we added variants for building documentation and debug builds (+doc + debug).
  • The PR adds support for more SGpp variants, specifically the Eigen, Dakota and Visualization variants (+eigen, +dakota, +visualization). Due to the way the SGpp SConstruct build system works, this required some additional logic in our Spack package to set the CPPPATH and the LIBPATH SCons variables correctly.
  • We also addressed an issue where the boost paths were not passed correctly to SCons like SGpp expects (resulting in issues during some tests). This required a fix within SGpp itself. This PR backports this change to some older SGpp versions in the Spack package by adding a patch.

Copy link
Copy Markdown

@pfluegdk pfluegdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge, thanks!

@G-071
Copy link
Copy Markdown
Contributor Author

G-071 commented Apr 10, 2025

@alalazo : I hope you don't mind that I suggested you as a reviewer for this PR just now. It's not like I am in a particular hurry; I just want to avoid the PR getting buried and you reviewed the last SGpp-related PR I did (#43178), so it seemed like a good idea.

@G-071 G-071 requested a review from alalazo April 10, 2025 12:04
@msimberg msimberg self-requested a review April 24, 2025 15:16
msimberg
msimberg previously approved these changes Apr 24, 2025
@msimberg msimberg merged commit 41489ef into spack:develop Apr 25, 2025
16 checks passed
danielsjensen1 added a commit to danielsjensen1/spack that referenced this pull request Apr 26, 2025
* develop: (752 commits)
  mesa: add v23.3.3 and use py-packaging while python>=3.12 (spack#49121)
  gcc: add v15.1.0 (spack#50212)
  draco: add v7.20.0 (spack#49996)
  sgpp: update dependencies and variants (spack#49384)
  input_analysis.py: fix conditional requirements (spack#50194)
  boost: add 1.88.0 (spack#50158)
  mapl: add v2.55.1 (spack#50201)
  mepo: add v2.3.2 (spack#50202)
  py-repligit: add v0.1.1 (spack#50204)
  [package updates] Bump version of cp2k and sirius (spack#50141)
  petsc4py: update ldshared.patch for v3.20.1, and skip for v3.23.1+ (spack#50170)
  namd: add v3.0.1 (spack#50192)
  geomodel: depend on c (spack#49781)
  CompilerAdaptor: add support for opt_flags/debug_flags (spack#50126)
  Add ls alias to spack {compiler, external} (spack#50189)
  covfie: depend on c (spack#50190)
  lua-sol2: add v3.5.0 (spack#49970)
  crtm-fix: fix directory logic (spack#50172)
  py-build: add v1.2.2 (spack#50148)
  py-pillow: fix build (spack#50177)
  ...
teaguesterling pushed a commit to teaguesterling/spack that referenced this pull request May 20, 2025
* sgpp: add new variants and constraints

* sgpp: fix format

* sgpp: add missing patch

* sgpp: fix style

* sgpp: Stop applying aarch patch for newer versions

* sgpp: Better Eigen variant description

Co-authored-by: Mikael Simberg <[email protected]>

* sgpp: fix format

---------

Co-authored-by: Mikael Simberg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants