Merged
wdconinc merged 8 commits intospack:developfrom Mar 13, 2025
Merged
Conversation
…kages/metplus/package.py
…ages/metplus/package.py
AlexanderRichert-NOAA
approved these changes
Feb 20, 2025
wdconinc
reviewed
Feb 22, 2025
Contributor
wdconinc
left a comment
wdconinc
left a comment
There was a problem hiding this comment.
Thanks for the additional versions. Checksums verified. Two comments.
Contributor
Author
|
@wdconinc I addressed your comments, please have another look. Sorry that this took so long. |
wdconinc
approved these changes
Mar 12, 2025
Contributor
wdconinc
left a comment
wdconinc
left a comment
There was a problem hiding this comment.
Sorry for the delay. Yes, still looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is cherry-picked from JCSDA#509 and adds
[email protected],[email protected],[email protected],[email protected]with their updated dependencies. This was tested at the Naval Research Lab and produced the same results as acondainstallation of these packages.