Adding ability for repo paths from a manifest file to be expanded when creating an environment.#49084
Merged
becker33 merged 4 commits intospack:developfrom Mar 4, 2025
Conversation
spackbot-app
bot
added
commands
core
…n creating an environment. A unit test was added to check that an environment variable will be expanded. Also, a bug was fixed in the expansion of develop paths where if an environment variable was in the path that then produced an absolute path the path would not be extended.
…n creating an environment. A unit test was added to check that an environment variable will be expanded. Also, a bug was fixed in the expansion of develop paths where if an environment variable was in the path that then produced an absolute path the path would not be extended.
fbrechin
force-pushed
the
expanding-relative-repo-paths-when-creating-envs
branch
from
c68fcc5 to
6bab18a
Compare
Contributor
Author
|
Just to note, the expansion of any relative repo paths is controlled by the existing I would be happy to change the new repo expansion control behavior in any way, including controlling it via a separate option if preferred or setting it to always be on. I do feel that the default behavior should be for this expansion to happen though. Feedback on this would be appreciated! |
becker33
approved these changes
Mar 4, 2025
This was referenced Jul 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding ability for repo paths from a manifest file to be expanded when creating an environment.
A unit test was added to check that an environment variable will be expanded. Also, a possible bug was fixed in the expansion of develop paths where if an environment variable was in the path that then produced an absolute path the path would not be extended.