Skip to content

nco: Add many versions and OpenMP support#49014

Merged
tldahlgren merged 4 commits intospack:developfrom
altheaden:update-nco
Mar 12, 2025
Merged

nco: Add many versions and OpenMP support#49014
tldahlgren merged 4 commits intospack:developfrom
altheaden:update-nco

Conversation

@altheaden
Copy link
Copy Markdown
Contributor

This PR adds many new versions to the nco package and also adds OpenMP support. I also added myself and @xylar as maintainers.

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Feb 12, 2025

@xylar can you review this PR?

This PR modifies the following package(s), for which you are listed as a maintainer:

  • nco

Copy link
Copy Markdown
Contributor

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@altheaden and I worked on this together. Looks great!

@xylar
Copy link
Copy Markdown
Contributor

xylar commented Feb 12, 2025

We work closely with @czender, the main developer of NCO. We also use NCO frequently in our spack workflows and have been maintaining and using these versions on our own fork (https://github.com/E3SM-Project/spack). It seemed like the right thing to do to contribute back to the broader spack community.

Copy link
Copy Markdown
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed all of the new sha256s. It is better to use the AutotoolsPackage helpers for setting variant arguments. See the suggestion I posted and give it a try.

@tldahlgren tldahlgren self-assigned this Feb 12, 2025
@altheaden altheaden force-pushed the update-nco branch 2 times, most recently from b7d1a6e to 1f30f97 Compare February 13, 2025 15:07
@altheaden
Copy link
Copy Markdown
Contributor Author

@tldahlgren Thank you for the help! I just implemented the changes you suggested.

@tldahlgren tldahlgren enabled auto-merge (squash) February 13, 2025 16:39
tldahlgren
tldahlgren previously approved these changes Feb 13, 2025
@xylar
Copy link
Copy Markdown
Contributor

xylar commented Feb 13, 2025

Thanks very much for the review, @tldahlgren!

auto-merge was automatically disabled February 18, 2025 16:13

Head branch was pushed to by a user without write access

@altheaden
Copy link
Copy Markdown
Contributor Author

@xylar I made those suggested changes and added 5.3.2.

@tldahlgren tldahlgren enabled auto-merge (squash) February 19, 2025 18:35
@xylar
Copy link
Copy Markdown
Contributor

xylar commented Mar 11, 2025

@tldahlgren @alalazo, we're wondering what the way forward is here. It seems that CI failed 2 weeks ago on a dependency package, netcdf-c:
https://gitlab.spack.io/spack/spack/-/jobs/15219138

checking whether we are cross compiling... configure: error: in `/tmp/gitlab-runner-1/spack-stage/spack-stage-netcdf-c-4.9.2-dlnjfxshv47hzz7ekcvo4yvptdbne75h/spack-src':
configure: error: cannot run C compiled programs.

This would appear to be an issue that might require attention from the maintainers of that package or the spack team but it doesn't seem to be directly related to nco.

What are your thoughts?

@xylar
Copy link
Copy Markdown
Contributor

xylar commented Mar 11, 2025

Thanks @tldahlgren. Good thought! Maybe recent changes will fix that issue.

@tldahlgren
Copy link
Copy Markdown
Contributor

Thanks @tldahlgren. Good thought! Maybe recent changes will fix that issue.

🤞

@tldahlgren tldahlgren merged commit de9aa3b into spack:develop Mar 12, 2025
16 checks passed
@xylar
Copy link
Copy Markdown
Contributor

xylar commented Mar 12, 2025

Thanks @tldahlgren!

@altheaden altheaden deleted the update-nco branch March 12, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants