nco: Add many versions and OpenMP support#49014
Conversation
|
@xylar can you review this PR? This PR modifies the following package(s), for which you are listed as a maintainer:
|
xylar
left a comment
There was a problem hiding this comment.
@altheaden and I worked on this together. Looks great!
67f04be to
9c74974
Compare
|
We work closely with @czender, the main developer of NCO. We also use NCO frequently in our spack workflows and have been maintaining and using these versions on our own fork (https://github.com/E3SM-Project/spack). It seemed like the right thing to do to contribute back to the broader spack community. |
tldahlgren
left a comment
There was a problem hiding this comment.
Confirmed all of the new sha256s. It is better to use the AutotoolsPackage helpers for setting variant arguments. See the suggestion I posted and give it a try.
b7d1a6e to
1f30f97
Compare
|
@tldahlgren Thank you for the help! I just implemented the changes you suggested. |
|
Thanks very much for the review, @tldahlgren! |
Head branch was pushed to by a user without write access
4237955 to
0ca5841
Compare
|
@xylar I made those suggested changes and added 5.3.2. |
0ca5841 to
4e111cb
Compare
|
@tldahlgren @alalazo, we're wondering what the way forward is here. It seems that CI failed 2 weeks ago on a dependency package, netcdf-c: This would appear to be an issue that might require attention from the maintainers of that package or the What are your thoughts? |
|
Thanks @tldahlgren. Good thought! Maybe recent changes will fix that issue. |
🤞 |
|
Thanks @tldahlgren! |
This PR adds many new versions to the
ncopackage and also adds OpenMP support. I also added myself and @xylar as maintainers.