packages: remove useless trailing commas#48790
Conversation
|
Hi @tgamblin! I noticed that the following package(s) don't yet have maintainers:
Are you interested in adopting any of these package(s)? If so, simply add the following to the package class: maintainers("tgamblin")If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with $ spack blame elementalThank you for your help! Please don't add maintainers without their consent. You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer. |
spackbot-app
bot
requested review from
afzpatel,
aumuell,
haampie,
kjrstory,
renjithravindrankannath and
srekolam
Some stray commas will result in two statements being interpreted (harmlessly, but still undesirably) as tuples. Remove them. Signed-off-by: Todd Gamblin <[email protected]>
tgamblin
force-pushed
the
fix-tuplecommas-in-packages
branch
from
20298e8 to
6a2b057
Compare
|
Did you do a full pass through builtin with using |
| if self.spec.satisfies("@:6.2"): | ||
| "-DHSAKMT_LIB={0}/lib".format(hsakmt_prefix), | ||
| "-DHSAKMT_LIB64={0}/lib64".format(hsakmt_prefix), | ||
| "-DHSAKMT_LIB={0}/lib".format(hsakmt_prefix) |
There was a problem hiding this comment.
Instead of fixing here I've included it in #48795, so might as well close this.
|
I ran |
|
Superseded by #48795. |
2 participants
Some stray commas will result in two statements being interpreted (harmlessly, but still undesirably) as tuples.
Remove them.