docs/Conflicts and requirements: elaborate on specs and provide link for more when arg examples#48773
Closed
tldahlgren wants to merge 3 commits intospack:developfrom
Closed
docs/Conflicts and requirements: elaborate on specs and provide link for more when arg examples#48773tldahlgren wants to merge 3 commits intospack:developfrom
tldahlgren wants to merge 3 commits intospack:developfrom
Conversation
spackbot-app
bot
added
core
scheibelp
requested changes
Jan 31, 2025
Member
scheibelp
left a comment
scheibelp
left a comment
There was a problem hiding this comment.
There's one issue where I think we are linking to the wrong section, and I have a suggestion.
| @@ -2789,13 +2798,15 @@ Adding the following to a package: | |||
| "please use a newer release." | |||
| ) | |||
Member
There was a problem hiding this comment.
(suggestion) I would recommend emphasizing that conflicts can be an arbitrary spec with compiler/version/architecture/dependency portions, and fleshing out this example to demonstrate.
Contributor
Author
There was a problem hiding this comment.
I expanded on part of this above and added another couple of examples below that are similar to some I've encountered reviewing PRs (nearly a month ago). Do you want more changes here?
Contributor
Author
|
Closing in favor of #51033 since the packaging guide has been split into multiple files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Questions about what specs are supported in conflicts args keep coming up so expand the main section in the docs to elaborate on args and provide a link to the "common"
when=cases.Post-1e018c3 version can be seen at https://spack--48773.org.readthedocs.build/en/48773/packaging_guide.html#conflicts-and-requirements.