Skip to content

trexio: add v2.2.3 -> master#48543

Merged
tldahlgren merged 3 commits intospack:developfrom
mtaillefumier:develop
Jan 14, 2025
Merged

trexio: add v2.2.3 -> master#48543
tldahlgren merged 3 commits intospack:developfrom
mtaillefumier:develop

Conversation

@mtaillefumier
Copy link
Copy Markdown
Contributor

@mtaillefumier mtaillefumier commented Jan 13, 2025

  • update version
  • add cmake support

@spackbot-app spackbot-app bot requested a review from scemama January 13, 2025 14:13
@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Jan 13, 2025

@q-posev can you review this PR?

This PR modifies the following package(s), for which you are listed as a maintainer:

  • trexio

@mtaillefumier mtaillefumier force-pushed the develop branch 2 times, most recently from 577fb95 to 38d1a27 Compare January 13, 2025 14:31
Update trexio
d23142d 
- update version
- add cmake support
@q-posev
Copy link
Copy Markdown
Contributor

q-posev commented Jan 13, 2025

Thank you @mtaillefumier ! Looks good to me but the review was requested from @scemama , let's wait for him

tldahlgren
tldahlgren previously approved these changes Jan 13, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the 6 new version sha256s.

@scemama @q-posev As maintainers, do either of you want to review this PR?

@tldahlgren tldahlgren self-assigned this Jan 13, 2025
@tldahlgren tldahlgren added the waiting-on-maintainer Waiting on a review from the package maintainer label Jan 13, 2025
@q-posev q-posev self-requested a review January 13, 2025 20:11
@q-posev
Copy link
Copy Markdown
Contributor

q-posev commented Jan 13, 2025

Thank you @tldahlgren ! The PR looks fine to me, though I do not use Spack at the moment and I am not aware of the latest best practices.

NB: since TREXIO >= 2.3.0, we no longer depend on the hdf5_hl library, so technically config_args.append("LIBS=-lhdf5_hl") and +hl in depends_on(hdf5...) are not required anymore.

@alecbcs alecbcs changed the title Update trexio trexio: add v2.2.3 -> master Jan 14, 2025
@tldahlgren
Copy link
Copy Markdown
Contributor

tldahlgren commented Jan 14, 2025

NB: since TREXIO >= 2.3.0, we no longer depend on the hdf5_hl library, so technically config_args.append("LIBS=-lhdf5_hl") and +hl in depends_on(hdf5...) are not required anymore.

Perhaps someone can create a follow-on PR to fix this?

@tldahlgren tldahlgren merged commit 308f74f into spack:develop Jan 14, 2025
@greenc-FNAL greenc-FNAL mentioned this pull request Jan 14, 2025
Merged
teaguesterling pushed a commit to teaguesterling/spack that referenced this pull request Feb 5, 2025
@mtaillefumier @teaguesterling
trexio: add v2.2.3 -> master (spack#48543)
247e414 
* Update trexio
   - update version
   - add cmake support

* Fix formating

* hdf5+hl only needed when < 2.3.0

---------

Co-authored-by: Mathieu Taillefumier <[email protected]>
@RMeli RMeli mentioned this pull request Feb 6, 2025
Merged
mrmundt pushed a commit to mrmundt/spack that referenced this pull request Feb 17, 2025
@mtaillefumier @mrmundt
trexio: add v2.2.3 -> master (spack#48543)
6759fa1 
* Update trexio
   - update version
   - add cmake support

* Fix formating

* hdf5+hl only needed when < 2.3.0

---------

Co-authored-by: Mathieu Taillefumier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tldahlgren tldahlgren tldahlgren approved these changes

+2 more reviewers

@scemama scemama scemama approved these changes

@q-posev q-posev q-posev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tldahlgren tldahlgren

Labels

dependencies new-version update-package waiting-on-maintainer Waiting on a review from the package maintainer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mtaillefumier @q-posev @tldahlgren @scemama