Merged
Conversation
spackbot-app
bot
requested review from
Hang-Lei-NOAA,
climbfuji,
edwardhartnett and
t-brown
|
@BenjaminTJohnson can you review this PR? This PR modifies the following package(s), for which you are listed as a maintainer:
|
Contributor
Author
|
@spackbot fix style |
|
Let me see if I can fix that for you! |
|
I was able to run spack style --fix==> Running style checks on spack
selected: import, isort, black, flake8, mypy
==> Modified files
var/spack/repos/builtin/packages/crtm/package.py
==> Running import checks
import check requires Python 3.9 or later
import checks were clean
==> Running isort checks
isort checks were clean
==> Running black checks
reformatted var/spack/repos/builtin/packages/crtm/package.py
All done! ✨ 🍰 ✨
1 file reformatted.
black checks were clean
==> Running flake8 checks
flake8 checks were clean
==> Running mypy checks
lib/spack/spack/version/version_types.py:135: error: Incompatible types in assignment (expression has type "Tuple[Any, ...]", variable has type "Tuple[str]") [assignment]
lib/spack/spack/variant.py:130: error: Unsupported right operand type for in ("Union[Collection[Any], Callable[..., Any]]") [operator]
Found 2 errors in 2 files (checked 634 source files)
mypy found errors
I've updated the branch with style fixes. |
Contributor
Author
|
@climbfuji mind giving this a quick glance? |
climbfuji
approved these changes
Jan 14, 2025
Contributor
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
Thanks, looks good to me!
tldahlgren
requested changes
Jan 14, 2025
Contributor
tldahlgren
left a comment
tldahlgren
left a comment
There was a problem hiding this comment.
Please correct the version check in url_for_version().
Co-authored-by: Tamara Dahlgren <[email protected]>
Contributor
Author
Done, thanks |
tldahlgren
approved these changes
Jan 14, 2025
climbfuji
pushed a commit
to climbfuji/spack
that referenced
this pull request
Jan 15, 2025
* add [email protected] * fix url_for_version's version check Co-authored-by: Tamara Dahlgren <[email protected]> --------- Co-authored-by: Tamara Dahlgren <[email protected]>
mtaillefumier
pushed a commit
to mtaillefumier/spack
that referenced
this pull request
Jan 20, 2025
* add [email protected] * fix url_for_version's version check Co-authored-by: Tamara Dahlgren <[email protected]> --------- Co-authored-by: Tamara Dahlgren <[email protected]>
AlexanderRichert-NOAA
added a commit
to AlexanderRichert-NOAA/spack
that referenced
this pull request
Jan 30, 2025
* add [email protected] * fix url_for_version's version check Co-authored-by: Tamara Dahlgren <[email protected]> --------- Co-authored-by: Tamara Dahlgren <[email protected]>
teaguesterling
pushed a commit
to teaguesterling/spack
that referenced
this pull request
Feb 5, 2025
* add [email protected] * fix url_for_version's version check Co-authored-by: Tamara Dahlgren <[email protected]> --------- Co-authored-by: Tamara Dahlgren <[email protected]>
mrmundt
pushed a commit
to mrmundt/spack
that referenced
this pull request
Feb 17, 2025
* add [email protected] * fix url_for_version's version check Co-authored-by: Tamara Dahlgren <[email protected]> --------- Co-authored-by: Tamara Dahlgren <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds crtm v3.1.1+build1.