Conversation
spackbot-app
bot
added
conflicts
dependencies
new-variant
new-version
update-package
labels
spackbot-app
bot
requested review from
Hang-Lei-NOAA,
edwardhartnett and
t-brown
|
@AlysonStahl-NOAA if it's okay with you I want to add you as a maintainer for the wgrib2 Spack recipe. You'll automatically get approval requests for any changes. |
|
@spackbot fix style |
|
Let me see if I can fix that for you! |
|
I was able to run spack style --fix==> Running style checks on spack
selected: import, isort, black, flake8, mypy
==> Modified files
var/spack/repos/builtin/packages/wgrib2/package.py
==> Running import checks
import check requires Python 3.9 or later
import checks were clean
==> Running isort checks
isort checks were clean
==> Running black checks
reformatted var/spack/repos/builtin/packages/wgrib2/package.py
All done! ✨ 🍰 ✨
1 file reformatted.
black checks were clean
==> Running flake8 checks
var/spack/repos/builtin/packages/wgrib2/package.py:6: [F401] 'os' imported but unused
var/spack/repos/builtin/packages/wgrib2/package.py:169: [W605] invalid escape sequence '\#'
flake8 found errors
==> Running mypy checks
lib/spack/spack/version/version_types.py:135: error: Incompatible types in assignment (expression has type "Tuple[Any, ...]", variable has type "Tuple[str]") [assignment]
lib/spack/spack/variant.py:130: error: Unsupported right operand type for in ("Union[Collection[Any], Callable[..., Any]]") [operator]
Found 2 errors in 2 files (checked 634 source files)
mypy found errors
I've updated the branch with style fixes. |
Yep, that's fine. |
|
@AlysonStahl-NOAA @edwardhartnett these updates come from what's in the wgrib2 repository, but the changes are pretty substantial, so please double check my work in terms of version requirements/dependencies, etc. I've tested installed 3.5 and 3.4 on my local machine but I haven't tested different combinations of variants and such, so please let me know if there's any particular build options that should be tested (e.g., ones that have caused trouble in the past). |
Co-authored-by: Massimiliano Culpo <[email protected]>
|
@spackbot fix style |
|
Let me see if I can fix that for you! |
|
I was able to run spack style --fix==> Running style checks on spack
selected: import, isort, black, flake8, mypy
==> Modified files
var/spack/repos/builtin/packages/wgrib2/package.py
==> Running import checks
import check requires Python 3.9 or later
import checks were clean
==> Running isort checks
isort checks were clean
==> Running black checks
reformatted var/spack/repos/builtin/packages/wgrib2/package.py
All done! ✨ 🍰 ✨
1 file reformatted.
black checks were clean
==> Running flake8 checks
flake8 checks were clean
==> Running mypy checks
lib/spack/spack/version/version_types.py:135: error: Incompatible types in assignment (expression has type "Tuple[Any, ...]", variable has type "Tuple[str]") [assignment]
lib/spack/spack/variant.py:130: error: Unsupported right operand type for in ("Union[Collection[Any], Callable[..., Any]]") [operator]
Found 2 errors in 2 files (checked 634 source files)
mypy found errors
I've updated the branch with style fixes. |
|
@edwardhartnett @Hang-Lei-NOAA please review, then we'll put the latest wgrib2 release in the next spack-stack release. |
Hang-Lei-NOAA
left a comment
Hang-Lei-NOAA
left a comment
There was a problem hiding this comment.
This wgrib2 version is from EMC repo.
wdconinc
left a comment
wdconinc
left a comment
There was a problem hiding this comment.
Sorry for the delay in reviewing this.
Co-authored-by: Wouter Deconinck <[email protected]>
* wgrib2: add cmake builder * wgrib2 add maintainer * [@spackbot] updating style on behalf of AlexanderRichert-NOAA * style fixes; add tar.gz for old vers * license update * wgrib2: don't restrict openjpeg variant by version * Update var/spack/repos/builtin/packages/wgrib2/package.py Co-authored-by: Massimiliano Culpo <[email protected]> * [@spackbot] updating style on behalf of AlexanderRichert-NOAA * Update package.py * Update package.py * Update var/spack/repos/builtin/packages/wgrib2/package.py Co-authored-by: Wouter Deconinck <[email protected]> --------- Co-authored-by: Massimiliano Culpo <[email protected]> Co-authored-by: Wouter Deconinck <[email protected]>
6 participants
This PR provides major updates to the wgrib2 package, specifically, it adds newer, CMake-based versions.