Skip to content

Make unit tests work on Ubuntu 24.04#48151

Merged
alalazo merged 1 commit intodevelopfrom
fix-kcov
Dec 20, 2024
Merged

Make unit tests work on Ubuntu 24.04#48151
alalazo merged 1 commit intodevelopfrom
fix-kcov

Conversation

@tgamblin
Copy link
Copy Markdown
Member

@tgamblin tgamblin commented Dec 17, 2024

kcov was removed in Ubuntu 24.04, and it is no longer installable via apt in our CI images. Instal it via Linuxbrew instead, at least until it comes back to Ubuntu.

subversion is also not installed on ubuntu 24 by default, so we have to install it manually.

  • Add linuxbrew to linux tests
  • Install kcov with brew
  • Install subversion with apt

@spackbot-app spackbot-app bot added core PR affects Spack core functionality workflow labels Dec 17, 2024
@tgamblin tgamblin requested a review from alalazo December 17, 2024 06:34
@alalazo
Copy link
Copy Markdown
Member

alalazo commented Dec 17, 2024

This one is still failing, I merged #48152 as a temporary workaround. In general, I think it would be better if we could prepare an image with Spack, and use it in CI. No need for linuxbrew 😉

@tgamblin tgamblin force-pushed the fix-kcov branch 2 times, most recently from 1a1cfa3 to bdccbb5 Compare December 20, 2024 05:01
`kcov` was removed in Ubuntu 24.04, and it is no longer
installable via `apt` in our CI images. Instal it via
Linuxbrew instead, at least until it comes back to Ubuntu.

`subversion` is also not installed on ubuntu 24 by default,
so we have to install it manually.

- [x] Add linuxbrew to linux tests
- [x] Install `kcov` with brew
- [x] Install subversion with `apt`

Signed-off-by: Todd Gamblin <[email protected]>
@tgamblin tgamblin changed the title Install kcov on Linux via Linuxbrew instead of Ubuntu Make unit tests work on ubuntu 24.04 Dec 20, 2024
@tgamblin tgamblin changed the title Make unit tests work on ubuntu 24.04 Make unit tests work on Ubuntu 24.04 Dec 20, 2024
@alalazo alalazo merged commit adbbb91 into develop Dec 20, 2024
@alalazo alalazo deleted the fix-kcov branch December 20, 2024 07:20
@alalazo
Copy link
Copy Markdown
Member

alalazo commented Dec 20, 2024

@haampie
Copy link
Copy Markdown
Member

haampie commented Dec 20, 2024

Also please use explicit versions instead of latest, so that release branches continue to work.

@alalazo alalazo added the v0.23.1 PRs to backport for v0.23.1 label Dec 20, 2024
tdrwenski pushed a commit to tdrwenski/spack that referenced this pull request Dec 26, 2024
`kcov` was removed in Ubuntu 24.04, and it is no longer
installable via `apt` in our CI images. Instal it via
Linuxbrew instead, at least until it comes back to Ubuntu.

`subversion` is also not installed on ubuntu 24 by default,
so we have to install it manually.

- [x] Add linuxbrew to linux tests
- [x] Install `kcov` with brew
- [x] Install subversion with `apt`

Signed-off-by: Todd Gamblin <[email protected]>
kshea21 pushed a commit to kshea21/spack that referenced this pull request Dec 26, 2024
`kcov` was removed in Ubuntu 24.04, and it is no longer
installable via `apt` in our CI images. Instal it via
Linuxbrew instead, at least until it comes back to Ubuntu.

`subversion` is also not installed on ubuntu 24 by default,
so we have to install it manually.

- [x] Add linuxbrew to linux tests
- [x] Install `kcov` with brew
- [x] Install subversion with `apt`

Signed-off-by: Todd Gamblin <[email protected]>
haampie pushed a commit that referenced this pull request Feb 3, 2025
`kcov` was removed in Ubuntu 24.04, and it is no longer
installable via `apt` in our CI images. Instal it via
Linuxbrew instead, at least until it comes back to Ubuntu.

`subversion` is also not installed on ubuntu 24 by default,
so we have to install it manually.

- [x] Add linuxbrew to linux tests
- [x] Install `kcov` with brew
- [x] Install subversion with `apt`

Signed-off-by: Todd Gamblin <[email protected]>
@haampie haampie mentioned this pull request Feb 3, 2025
27 tasks
teaguesterling pushed a commit to teaguesterling/spack that referenced this pull request Feb 5, 2025
`kcov` was removed in Ubuntu 24.04, and it is no longer
installable via `apt` in our CI images. Instal it via
Linuxbrew instead, at least until it comes back to Ubuntu.

`subversion` is also not installed on ubuntu 24 by default,
so we have to install it manually.

- [x] Add linuxbrew to linux tests
- [x] Install `kcov` with brew
- [x] Install subversion with `apt`

Signed-off-by: Todd Gamblin <[email protected]>
mrmundt pushed a commit to mrmundt/spack that referenced this pull request Feb 17, 2025
`kcov` was removed in Ubuntu 24.04, and it is no longer
installable via `apt` in our CI images. Instal it via
Linuxbrew instead, at least until it comes back to Ubuntu.

`subversion` is also not installed on ubuntu 24 by default,
so we have to install it manually.

- [x] Add linuxbrew to linux tests
- [x] Install `kcov` with brew
- [x] Install subversion with `apt`

Signed-off-by: Todd Gamblin <[email protected]>
haampie pushed a commit that referenced this pull request Feb 19, 2025
`kcov` was removed in Ubuntu 24.04, and it is no longer
installable via `apt` in our CI images. Instal it via
Linuxbrew instead, at least until it comes back to Ubuntu.

`subversion` is also not installed on ubuntu 24 by default,
so we have to install it manually.

- [x] Add linuxbrew to linux tests
- [x] Install `kcov` with brew
- [x] Install subversion with `apt`

Signed-off-by: Todd Gamblin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core PR affects Spack core functionality shell-support v0.23.1 PRs to backport for v0.23.1 workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants