Skip to content

filter_file: make tempfile later#48108

Merged
wdconinc merged 2 commits intodevelopfrom
hs/fix/filter_file-take-2
Dec 13, 2024
Merged

filter_file: make tempfile later#48108
wdconinc merged 2 commits intodevelopfrom
hs/fix/filter_file-take-2

Conversation

@haampie
Copy link
Copy Markdown
Member

@haampie haampie commented Dec 13, 2024

the tempfile can only be created if the dir of the file exists

@spackbot-app spackbot-app bot added core PR affects Spack core functionality utilities labels Dec 13, 2024
@haampie haampie added the hotfix label Dec 13, 2024
Copy link
Copy Markdown
Contributor

@wdconinc wdconinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@wdconinc wdconinc enabled auto-merge (squash) December 13, 2024 17:22
@wdconinc wdconinc merged commit a07e372 into develop Dec 13, 2024
@wdconinc wdconinc deleted the hs/fix/filter_file-take-2 branch December 13, 2024 18:49
@haampie haampie added the v0.23.1 PRs to backport for v0.23.1 label Dec 13, 2024
tdrwenski pushed a commit to tdrwenski/spack that referenced this pull request Dec 26, 2024
* filter_file: make tempfile later

* also add a `.` after the filename
kshea21 pushed a commit to kshea21/spack that referenced this pull request Dec 26, 2024
* filter_file: make tempfile later

* also add a `.` after the filename
haampie added a commit that referenced this pull request Feb 3, 2025
* filter_file: make tempfile later

* also add a `.` after the filename
@haampie haampie mentioned this pull request Feb 3, 2025
27 tasks
teaguesterling pushed a commit to teaguesterling/spack that referenced this pull request Feb 5, 2025
* filter_file: make tempfile later

* also add a `.` after the filename
haampie added a commit that referenced this pull request Feb 19, 2025
* filter_file: make tempfile later

* also add a `.` after the filename
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core PR affects Spack core functionality hotfix utilities v0.23.1 PRs to backport for v0.23.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants