Skip to content
Merged
scheibelp merged 8 commits intospack:developfrom
climbfuji:feature/py_cylc_flow_836_spack_Dev
Jan 10, 2025
Merged

Add [email protected], [email protected], [email protected], [email protected], [email protected]#48052
scheibelp merged 8 commits intospack:developfrom
climbfuji:feature/py_cylc_flow_836_spack_Dev

Conversation

@climbfuji
Copy link
Copy Markdown
Contributor

@climbfuji climbfuji commented Dec 11, 2024

Description

  1. Add [email protected] (needed for [email protected]).
  2. Add [email protected] and enable png output when creating graphs by requesting variant pangocairo for graphviz dependency.
  3. Add corresponding versions of [email protected], [email protected], [email protected].
  4. Add myself as maintainer to all the cylc-related packages.

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Dec 11, 2024

Hi @climbfuji! I noticed that the following package(s) don't yet have maintainers:

  • py-protobuf

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers("climbfuji")

If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with spack blame:

$ spack blame py-protobuf

Thank you for your help! Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

@climbfuji
Copy link
Copy Markdown
Contributor Author

@spackbot fix style

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Dec 11, 2024

Let me see if I can fix that for you!

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Dec 11, 2024

I was able to run spack style --fix for you!

spack style --fix
==> Running style checks on spack
  selected: import, isort, black, flake8, mypy
==> Modified files
  var/spack/repos/builtin/packages/py-cylc-flow/package.py
  var/spack/repos/builtin/packages/py-protobuf/package.py
==> Running import checks
import check requires Python 3.9 or later
  import checks were clean
==> Running isort checks
  isort checks were clean
==> Running black checks
reformatted var/spack/repos/builtin/packages/py-cylc-flow/package.py
All done! ✨ 🍰 ✨
1 file reformatted, 1 file left unchanged.
  black checks were clean
==> Running flake8 checks
  flake8 checks were clean
==> Running mypy checks
lib/spack/spack/version/version_types.py:135: error: Incompatible types in assignment (expression has type "Tuple[Any, ...]", variable has type "Tuple[str]")  [assignment]
lib/spack/spack/variant.py:131: error: Unsupported right operand type for in ("Union[Collection[Any], Callable[..., Any]]")  [operator]
Found 2 errors in 2 files (checked 631 source files)
  mypy found errors
Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. If I was able to push to your branch, if you make further changes you will need to pull from your updated branch before pushing again.

I've updated the branch with style fixes.

@climbfuji climbfuji requested a review from scheibelp December 18, 2024 21:24
@climbfuji climbfuji marked this pull request as draft December 19, 2024 23:30
@climbfuji climbfuji force-pushed the feature/py_cylc_flow_836_spack_Dev branch from 748e2dc to aa2db30 Compare December 27, 2024 19:30
@climbfuji
Copy link
Copy Markdown
Contributor Author

I've removed all changes related to PYTHONPATH or CYLC_PYTHONPATH, leaving the logic as is for now (working with the cylc developers in their repository on a solution). I added the corresponding versions and dependencies of other cylc packages. This PR is now ready for review.

@climbfuji climbfuji marked this pull request as ready for review December 27, 2024 19:35
@climbfuji
Copy link
Copy Markdown
Contributor Author

@teaguesterling @LydDeb @scheibelp Gentle reminder about this PR, thanks!

climbfuji added a commit to JCSDA/spack that referenced this pull request Jan 9, 2025
Add recent versions of py-cylc-flow, py-cylc-rose, py-cylc-uiserver, and their dependency py-protobuf (spack PR spack#48052); pull spack PRs spack#48251 ([email protected] - intel classic conflict) and spack#48478 (comment out [email protected])
Copy link
Copy Markdown
Contributor

@teaguesterling teaguesterling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm with the pypi comments!

@scheibelp
Copy link
Copy Markdown
Member

@spackbot run pipeline

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Jan 9, 2025

I've started that pipeline for you!

@scheibelp scheibelp merged commit d6a9511 into spack:develop Jan 10, 2025
@climbfuji climbfuji deleted the feature/py_cylc_flow_836_spack_Dev branch January 13, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants