Skip to content

Ascii filter output#48001

Closed
kwryankrattiger wants to merge 2 commits intospack:developfrom
kwryankrattiger:ascii_filter_output
Closed

Ascii filter output#48001
kwryankrattiger wants to merge 2 commits intospack:developfrom
kwryankrattiger:ascii_filter_output

Conversation

@kwryankrattiger
Copy link
Copy Markdown
Contributor

Filter non-ascii unicode when printing build output.

Handle UnicodeDecodeError when fetching build logs in report that contain non-ascii characters.

@spackbot-app spackbot-app bot added the core PR affects Spack core functionality label Dec 10, 2024
@haampie
Copy link
Copy Markdown
Member

haampie commented Dec 10, 2024

This is not the right direction, actually the opposite.

@haampie
Copy link
Copy Markdown
Member

haampie commented Dec 10, 2024

I'm closing this since it has various issues. We want utf-8 output, we just don't want to print utf-8 strings when sys.stdout isn't using utf-8 encoding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core PR affects Spack core functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants