Skip to content

bug fix: updated warning message to reflect impending v1.0 release#47887

Merged
alalazo merged 3 commits intospack:developfrom
carsonwoods:bug/warning-message
Dec 3, 2024
Merged

bug fix: updated warning message to reflect impending v1.0 release#47887
alalazo merged 3 commits intospack:developfrom
carsonwoods:bug/warning-message

Conversation

@carsonwoods
Copy link
Copy Markdown
Contributor

This PR makes a tiny 1-line change to update the deprecation message on the config:install_missing_compilers config option to say it will be removed in v1.0 instead of v0.25.

This PR was motivated by a gripe in the Spack Slack.

@spackbot-app spackbot-app bot added the core PR affects Spack core functionality label Dec 3, 2024
Updated wording from "in" to "after" to clarify removal timeline.
@alalazo alalazo self-assigned this Dec 3, 2024
@carsonwoods
Copy link
Copy Markdown
Contributor Author

@spackbot help

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Dec 3, 2024

You can interact with me in many ways!

  • @spackbot hello: say hello and get a friendly response back!
  • @spackbot help or @spackbot commands: see this message
  • @spackbot run pipeline or @spackbot re-run pipeline: to request a new run of the GitLab CI pipeline
  • @spackbot rebuild everything: to run a pipeline rebuilding all specs from source.
  • @spackbot fix style if you have write and would like me to run spack style --fix for you.
  • @spackbot maintainers or @spackbot request review: to look for and assign reviewers for the pull request.

I'll also help to label your pull request and assign reviewers!
If you need help or see there might be an issue with me, open an issue here

@carsonwoods
Copy link
Copy Markdown
Contributor Author

@spackbot run pipeline

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Dec 3, 2024

I've started that pipeline for you!

@alalazo alalazo merged commit a7eacd7 into spack:develop Dec 3, 2024
@alalazo alalazo added the v0.23.1 PRs to backport for v0.23.1 label Dec 3, 2024
@haampie haampie mentioned this pull request Feb 3, 2025
27 tasks
teaguesterling pushed a commit to teaguesterling/spack that referenced this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core PR affects Spack core functionality v0.23.1 PRs to backport for v0.23.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants