Hey @haampie, I tried out this patch, and it does not currently work on it's own. I tried to debug when the hard-link gets broken, and to me it seems like it happens already when the bin/git binary is relocated, i.e. before codesign runs.

I tried adding the same temporary file mechanism to the install_name_tool invocation, and that seems to work for me.

I have a patch for this in this gist.

Hm, forgot that we used that. That's rather annoying, install name tool technically has no good reason to modify files out of place. Maybe a regression in the tool?

It could be. It's not obvious to me how install_name_tool is supposed to behave with hardlinks.

If it is a regression, would you want to gate the workaround based on tool version? Otherwise, is there any reason not to apply the workaround?

the workaround is fine, just wish we didn't have to. if it's a regression we should report a bug with xcode.

Need to wrap more calls to install_name_tool still. Not entirely happy about the g.flush() bit, but don't see an obvious way to avoid doubly closing the file descriptor.