Merged
Conversation
spackbot-app
bot
requested review from
AlexanderRichert-NOAA,
Hang-Lei-NOAA,
climbfuji,
edwardhartnett and
tclune
14 tasks
climbfuji
reviewed
Nov 15, 2024
Contributor
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
not a spack guru, but looks correct to me
Contributor
Yes, your dependency says it MUST be 8.6.1 or higher for 2.40.3.1. |
fryeguy52
pushed a commit
to fryeguy52/spack
that referenced
this pull request
Dec 17, 2024
* mapl: add 2.40.3.1 * Relax ESMF requirement
kshea21
pushed a commit
to kshea21/spack
that referenced
this pull request
Dec 26, 2024
* mapl: add 2.40.3.1 * Relax ESMF requirement
climbfuji
pushed a commit
to climbfuji/spack
that referenced
this pull request
Jan 24, 2025
* mapl: add 2.40.3.1 * Relax ESMF requirement
nkoukpaizan
pushed a commit
to nkoukpaizan/spack
that referenced
this pull request
Apr 4, 2025
* mapl: add 2.40.3.1 * Relax ESMF requirement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds MAPL 2.40.3.1. This is a weird, special tag of MAPL that is like v2.40.3 but requires ESMF 8.6.1
Can an Spack Guru take a look at my changes please? I want to make sure I did the
depends_onright. I want to say: "If v2.40.3.1, use ESMF 8.6.1 or higher...but don't screw up versions around it"