Conversation
…v installs Fixes a change in behavior/bug in 7041261, where partial environment installs would mark the selected spec as explicitly installed, even if it was not a root of the environment. The desired behavior is that roots by definition are the to be explicitly installed specs. The specs on the `spack -e ... install x` command line are just filters for partial installs, so leave them implicitly installed if they aren't roots.
spackbot-app
bot
added
core
tgamblin
approved these changes
Oct 23, 2024
eugeneswalker
pushed a commit
to eugeneswalker/spack
that referenced
this pull request
Nov 1, 2024
…v installs (spack#47183) Fixes a change in behavior/bug in 7041261, where partial environment installs would mark the selected spec as explicitly installed, even if it was not a root of the environment. The desired behavior is that roots by definition are the to be explicitly installed specs. The specs on the `spack -e ... install x` command line are just filters for partial installs, so leave them implicitly installed if they aren't roots.
eugeneswalker
pushed a commit
that referenced
this pull request
Nov 5, 2024
…v installs (#47183) Fixes a change in behavior/bug in 7041261, where partial environment installs would mark the selected spec as explicitly installed, even if it was not a root of the environment. The desired behavior is that roots by definition are the to be explicitly installed specs. The specs on the `spack -e ... install x` command line are just filters for partial installs, so leave them implicitly installed if they aren't roots.
This was referenced Nov 25, 2024
haampie
added a commit
that referenced
this pull request
Feb 18, 2025
…v installs (#47183) Fixes a change in behavior/bug in 7041261, where partial environment installs would mark the selected spec as explicitly installed, even if it was not a root of the environment. The desired behavior is that roots by definition are the to be explicitly installed specs. The specs on the `spack -e ... install x` command line are just filters for partial installs, so leave them implicitly installed if they aren't roots.
haampie
added a commit
that referenced
this pull request
Feb 19, 2025
…v installs (#47183) Fixes a change in behavior/bug in 7041261, where partial environment installs would mark the selected spec as explicitly installed, even if it was not a root of the environment. The desired behavior is that roots by definition are the to be explicitly installed specs. The specs on the `spack -e ... install x` command line are just filters for partial installs, so leave them implicitly installed if they aren't roots.
vjranagit
pushed a commit
to vjranagit/spack
that referenced
this pull request
Jan 18, 2026
…v installs (spack#47183) Fixes a change in behavior/bug in 244b416, where partial environment installs would mark the selected spec as explicitly installed, even if it was not a root of the environment. The desired behavior is that roots by definition are the to be explicitly installed specs. The specs on the `spack -e ... install x` command line are just filters for partial installs, so leave them implicitly installed if they aren't roots.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a change in behavior/bug in 7041261, where partial environment
installs would mark the selected spec as explicitly installed, even if
it was not a root of the environment.
The desired behavior is that roots by definition are the to be
explicitly installed specs. The specs on the
spack -e ... install xcommand line are just filters for partial environment installs,
that should not influence explicit/implicit installs.