Merged
Conversation
Contributor
Author
|
@spackbot fix style |
|
Let me see if I can fix that for you! |
|
I was able to run spack style --fix==> Running style checks on spack
selected: isort, black, flake8, mypy
==> Modified files
var/spack/repos/builtin/packages/adios2/package.py
var/spack/repos/builtin/packages/sz/package.py
==> Running isort checks
isort checks were clean
==> Running black checks
reformatted var/spack/repos/builtin/packages/sz/package.py
reformatted var/spack/repos/builtin/packages/adios2/package.py
All done! ✨ 🍰 ✨
2 files reformatted.
black checks were clean
==> Running flake8 checks
flake8 checks were clean
==> Running mypy checks
lib/spack/spack/version/version_types.py:145: error: Argument 2 to "StandardVersion" has incompatible type "*Tuple[Tuple[Any, ...], Tuple[Any, ...]]"; expected "Tuple[Tuple[Any, ...], Tuple[Any, ...]]" [arg-type]
lib/spack/spack/version/version_types.py:452: error: Argument 2 to "StandardVersion" has incompatible type "*Tuple[Tuple[Any, ...], Tuple[Any, ...]]"; expected "Tuple[Tuple[Any, ...], Tuple[Any, ...]]" [arg-type]
lib/spack/spack/version/version_types.py:481: error: Argument 2 to "StandardVersion" has incompatible type "*Tuple[Tuple[Any, ...], Tuple[Any, ...]]"; expected "Tuple[Tuple[Any, ...], Tuple[Any, ...]]" [arg-type]
lib/spack/spack/variant.py:131: error: Unsupported right operand type for in ("Union[Collection[Any], Callable[..., Any]]") [operator]
Found 4 errors in 2 files (checked 621 source files)
mypy found errors
I've updated the branch with style fixes. |
johnwparent
force-pushed
the
win/port-adios2-2
branch
from
e7818c3 to
6a90c63
Compare
Contributor
Author
|
@spackbot fix style |
scheibelp
reviewed
Oct 22, 2024
Member
scheibelp
left a comment
scheibelp
left a comment
There was a problem hiding this comment.
The PR description mentions conflicts, which normally I would consider more robust than variant default values.
I'm not strictly against this but wanted to get a response before approving.
scheibelp
previously approved these changes
Mar 11, 2025
Adios2 was ported in 2023 but seems to have regressed via new variants and associated deps in the last year. Conflcit with those deps for now until they can be ported
johnwparent
force-pushed
the
win/port-adios2-2
branch
from
6573e1b to
88bdf5b
Compare
scheibelp
approved these changes
Mar 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adios2 was ported in 2023 but seems to have regressed via new variants and associated deps in the last year. Conflcit with those deps for now until they can be ported