Merged
Conversation
Remove the `build-tools` tag of python, otherwise these types of
concretizations are possible:
```
py-root
^py-pip
^[email protected]
^[email protected]
```
So, a package would be configured with py-pip using python 3.12, but
installed for 3.13, which does not work.
alalazo
approved these changes
Oct 15, 2024
Member
|
To re-enable the "build-tools" tag on Python, we need extra rules in clingo for interpreted languages that ensures build only deps that are extensions always use the same interpreter as their parent. |
arezaii
pushed a commit
to arezaii/spack
that referenced
this pull request
Oct 22, 2024
Remove the `build-tools` tag of python, otherwise these types of
concretizations are possible:
```
py-root
^py-pip
^[email protected]
^[email protected]
```
So, a package would be configured with py-pip using python 3.12, but
installed for 3.13, which does not work.
This was referenced Oct 30, 2024
Merged
haampie
added a commit
that referenced
this pull request
Oct 31, 2024
Remove the `build-tools` tag of python, otherwise these types of
concretizations are possible:
```
py-root
^py-pip
^[email protected]
^[email protected]
```
So, a package would be configured with py-pip using python 3.12, but
installed for 3.13, which does not work.
haampie
added a commit
that referenced
this pull request
Nov 18, 2024
Remove the `build-tools` tag of python, otherwise these types of
concretizations are possible:
```
py-root
^py-pip
^[email protected]
^[email protected]
```
So, a package would be configured with py-pip using python 3.12, but
installed for 3.13, which does not work.
2 tasks
tgamblin
pushed a commit
that referenced
this pull request
Feb 26, 2025
Python was removed from being a build tool in #46980, due to issues when reusing specs. This PR adds a new rule to match the interpreter among different Python packages, in clingo. It also adds a bunch of new "build-tools", so that specs like: ``` py-matplotlib backend=tkagg ``` can be concretized in one go. Modifications: - [x] Make `py-matplotlib backend=tkagg` concretizable - [x] Add unit-tests to ensure situations like in #46980 do not happen --------- Signed-off-by: Massimiliano Culpo <[email protected]>
white238
pushed a commit
that referenced
this pull request
Mar 3, 2025
Python was removed from being a build tool in #46980, due to issues when reusing specs. This PR adds a new rule to match the interpreter among different Python packages, in clingo. It also adds a bunch of new "build-tools", so that specs like: ``` py-matplotlib backend=tkagg ``` can be concretized in one go. Modifications: - [x] Make `py-matplotlib backend=tkagg` concretizable - [x] Add unit-tests to ensure situations like in #46980 do not happen --------- Signed-off-by: Massimiliano Culpo <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the
build-toolstag of python, otherwise these types ofconcretizations are possible:
So, a package would be configured with py-pip using python 3.12, but
installed for 3.13, which does not work.