py-scipy: Set Fortran_std correctly for builds with AOCC and llvm-flang#46922
py-scipy: Set Fortran_std correctly for builds with AOCC and llvm-flang#46922adamjstewart merged 1 commit intospack:developfrom
Conversation
bernhardkaindl
left a comment
bernhardkaindl
left a comment
There was a problem hiding this comment.
Build results on Ubuntu 22.04.4 LTS:
bin/spack find --variants py-scipy
-- linux-ubuntu22.04-skylake / gcc@13.1.0 -----------------------
py-scipy@1.14.1/home/bkaindl/build-quality-tools/build_pr_changes.py --approve --yes
adamjstewart
left a comment
adamjstewart
left a comment
There was a problem hiding this comment.
Would like to hear from @rgommers before merging
bernhardkaindl
added
the
waiting-on-maintainer
rgommers
left a comment
rgommers
left a comment
There was a problem hiding this comment.
This LGTM. I need to figure out what the problem is in Meson with using legacy, but this can't hurt so fine to merge.
|
An FYI on this one: for SciPy 1.15.0, I disabled the use of |
|
Should we change it to: if spec.satisfies("%gcc"):
fortran_std = "legacy"
else:
fortran_std = "none"? It's tricky because people often mix compilers, e.g., Apple Clang + GFortran. @alalazo is the new compilers as dependencies logic mature enough to detect this yet, or is that still a work in progress? |
|
Either way works I think, the problem is probably already solved well enough, but it also can't hurt to match the change I made in SciPy. |
5 participants
AOCCandLLVM Flang @18:require fortran std to be set tononerather thanlegacyfor meson builds.