Do not use single letter packages in unit-tests#46665
Merged
tldahlgren merged 1 commit intospack:developfrom Oct 1, 2024
Merged
Do not use single letter packages in unit-tests#46665tldahlgren merged 1 commit intospack:developfrom
tldahlgren merged 1 commit intospack:developfrom
Conversation
spack#45205 already removed previous use of single letter packages from unit tests, in view of reserving `c` as a language (see spack#45191). Some use of them has been re-introduced accidentally in spack#46382, and is making unit-tests fail in the feature branch spack#45189 since there `c` is a virtual package. Signed-off-by: Massimiliano Culpo <[email protected]>
spackbot-app
bot
added
core
tldahlgren
approved these changes
Sep 30, 2024
arezaii
pushed a commit
to arezaii/spack
that referenced
this pull request
Oct 22, 2024
spack#45205 already removed previous use of single letter packages from unit tests, in view of reserving `c` as a language (see spack#45191). Some use of them has been re-introduced accidentally in spack#46382, and is making unit-tests fail in the feature branch spack#45189 since there `c` is a virtual package. Signed-off-by: Massimiliano Culpo <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#45205 already removed previous use of single letter packages from unit tests, in view of reserving
cas a language (see #45191).Some use of them has been re-introduced accidentally in #46382, and is making unit-tests fail in the feature branch #45189 since there
cis a virtual package.