fd: add minimum rustc version requirement#46622
Merged
alecbcs merged 1 commit intospack:developfrom Sep 29, 2024
Merged
Conversation
ashermancinelli
approved these changes
Sep 28, 2024
Contributor
ashermancinelli
left a comment
There was a problem hiding this comment.
I looked up Cargo.toml in the repo for each tag, these look right. Thanks!
alecbcs
approved these changes
Sep 28, 2024
Member
alecbcs
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks @pranav-sivaraman!
teaguesterling
pushed a commit
to teaguesterling/spack
that referenced
this pull request
Oct 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into an issue building
fdwith an external[email protected]. Updating the minimumrustforfdby checking theCargo.tomlfor each release tag.