Skip to content

fd: add minimum rustc version requirement#46622

Merged
alecbcs merged 1 commit intospack:developfrom
pranav-sivaraman:package/fd-rustc-bounds
Sep 29, 2024
Merged

fd: add minimum rustc version requirement#46622
alecbcs merged 1 commit intospack:developfrom
pranav-sivaraman:package/fd-rustc-bounds

Conversation

@pranav-sivaraman
Copy link
Copy Markdown
Contributor

Ran into an issue building fd with an external [email protected]. Updating the minimum rust for fd by checking the Cargo.toml for each release tag.

Copy link
Copy Markdown
Contributor

@ashermancinelli ashermancinelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked up Cargo.toml in the repo for each tag, these look right. Thanks!

Copy link
Copy Markdown
Member

@alecbcs alecbcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @pranav-sivaraman!

@alecbcs alecbcs enabled auto-merge (squash) September 28, 2024 16:20
@alecbcs alecbcs self-assigned this Sep 28, 2024
@alecbcs alecbcs merged commit 343586d into spack:develop Sep 29, 2024
@pranav-sivaraman pranav-sivaraman deleted the package/fd-rustc-bounds branch September 29, 2024 04:39
teaguesterling pushed a commit to teaguesterling/spack that referenced this pull request Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants