Open
Conversation
spackbot-app
bot
added
core
Member
Author
|
@Chrismarsh does this fix your issue mentioned in #46536 (comment)? (just the last commit -- this is based on #46536) |
Contributor
|
@tgamblin Looks like it does. I pulled this and ran it against |
Member
Author
|
Great! Something else is broken here -- I'll work on it |
We have special logic in `cc` to *not* add RPATH arguments on macOS
when using `-r` as a linker argument, but it's applied every time we
append/extend RPATH lists, and it's not applied consistently.
- [x] Fix this by just not appending *any* parsed RPATHs on macOS
when `-r` is present, instead of handling it on every insertion.
- [x] Simplify logic using the recently added `contains()` function.
Signed-off-by: Todd Gamblin <[email protected]>
tgamblin
force-pushed
the
fix-rpath-r-arg-handling
branch
from
83bed01 to
0a38541
Compare
Contributor
|
With the now reverted #46536 this no longer works for me and parallel-netcdf continues to fail to build for me and @adamjstewart, e.g., #46811. I'm wondering if there is anything else I can test to help? |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #46264.
Fixes #45479.
Needs #46536 (based on it)
We have special logic in
ccto not add RPATH arguments on macOS when using-ras a linker argument, but it's applied every time we append/extend RPATH lists, and it's not applied consistently.-ris present, instead of handling it on every insertion.contains()function.