database: don't call socket.getfqdn() on every write#46554
Merged
Conversation
Member
Author
|
Let's see if this speeds up macOS CI. |
We've seen `getfqdn()` cause slowdowns on macOS in CI when added elsewhere. It's also called by database.py every time we write the DB file. - [x] replace the call with a memoized version so that it is only called once per process. Signed-off-by: Todd Gamblin <[email protected]>
tgamblin
force-pushed
the
cache-getfqdn
branch
from
00d1816 to
6e25f66
Compare
Member
Author
Member
Author
|
@Jordan474: FYI, see above. Your #45522 has apparently clued us into a long-standing performance issue. I think we can get this one merged, then maybe you can submit a refactored #45522 using a cached @alalazo any particular place you think the cached call should live? |
Member
Author
|
@haampie FYI |
4 tasks
This was referenced Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've seen
getfqdn()cause slowdowns on macOS in CI when added elsewhere. It's also called by database.py every time we write the DB file.