Merged
Conversation
Signed-off-by: Massimiliano Culpo <[email protected]>
Signed-off-by: Massimiliano Culpo <[email protected]>
Member
Author
|
Benchmarked on:
radiuss.develop.csv It seems to behave generally better also on |
1 task
tgamblin
approved these changes
Sep 24, 2024
Member
tgamblin
left a comment
There was a problem hiding this comment.
@alalazo LGTM. Can you please, in a follow-up, add the description from the PR to the comments in heuristic.lp? I think it'll help for long-term maintenance if these are documented in the code.
Merging now, based on the benchmark results, and leaving comment updates for future PR.s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Extracted from #45189
This PR introduces a new heuristic for the solver, which behaves better when compilers are treated as nodes. Apparently, it performs better also on
develop, where compilers are still node attributes.The new heuristic:
attr("variant", Node, Variant, Value)is false, but if we know that the node is already in the answer set, and the value is the default one, then we guess it is true.