Remove spack.target from code#46503
Conversation
Signed-off-by: Massimiliano Culpo <[email protected]>
This argument is not used anymore in any code path Signed-off-by: Massimiliano Culpo <[email protected]>
Signed-off-by: Massimiliano Culpo <[email protected]>
Signed-off-by: Massimiliano Culpo <[email protected]>
Signed-off-by: Massimiliano Culpo <[email protected]>
Signed-off-by: Massimiliano Culpo <[email protected]>
spackbot-app
bot
added
architecture
build-environment
compilers
core
|
Hi @alalazo! I noticed that the following package(s) don't yet have maintainers:
Are you interested in adopting any of these package(s)? If so, simply add the following to the package class: maintainers("alalazo")If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with $ spack blame hpccThank you for your help! Please don't add maintainers without their consent. You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer. |
spackbot-app
bot
requested review from
adamjstewart,
amd-toolchain-support,
aweits,
brenthuisman,
iomaganaris,
jcphill,
matz-e,
ohm314,
pramodk,
rbberger and
thorstenhater
|
@nrnhines can you review this PR? This PR modifies the following package(s), for which you are listed as a maintainer:
|
Signed-off-by: Massimiliano Culpo <[email protected]>
rbberger
left a comment
rbberger
left a comment
There was a problem hiding this comment.
LGTM for the lammps package.
|
Signed-off-by: Massimiliano Culpo <[email protected]>
spackbot-app
bot
added
the
documentation
Note that these packages rely on "internal" API calls, which are not stable. Spack injects the same flags through the wrapper. Signed-off-by: Massimiliano Culpo <[email protected]>
|
The only failure seems unrelated to the PR: https://gitlab.spack.io/spack/spack/-/jobs/12614028 |
|
Adding |
Use commit bceb39528ac49dd0c876b2e9bf3e7482e9c2be4a
|
The only conflict is the sha, that can also be solved in the backport PR. We can keep archspec updates always separate in the future. For what is worth, the changes in |
Use commit bceb39528ac49dd0c876b2e9bf3e7482e9c2be4a
5 participants
The
spack.target.Targetclass is a weird entity, that is just needed to:This PR removes it, and uses
archspec.cpu.Microarchitecturedirectly. To sort lists, we use a properkey=when needed. Being able to useMicroarchitectureobjects in sets is achieved by updating the externalarchspec.We might clean the code further, in following PRs, by introducing microarchitecture ranges in
ArchSpec, and simplifying the constrain etc. logic.