Ensure spack_store_rpath_dirs_list is empty when add_rpaths is false#46264
Closed
Chrismarsh wants to merge 1 commit intospack:developfrom
Closed
Ensure spack_store_rpath_dirs_list is empty when add_rpaths is false#46264Chrismarsh wants to merge 1 commit intospack:developfrom
Chrismarsh wants to merge 1 commit intospack:developfrom
Conversation
3 tasks
3 tasks
Chrismarsh
force-pushed
the
package-fix/spack-cc-45919
branch
from
d825ecb to
6391747
Compare
Member
|
See #48671. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #45919
If a compiler is defined to have
extra_rpathsthese are passed in as-Wl,-rpath. Thus, this arg gets stored intoreturn_spack_store_rpath_dirs_list, viaparse_Wl, and ultimately intospack_store_rpath_dirs_list. The rpath then is added unconditionally toargs_listinccldmode even if$add_rpaths=false. Not adding rpaths is required on darwin when using the -r flag. The existing rpath protection on darwin does not consider this edge case, so this PR adds it by ensuring any-Wl,-rpathdetected rpaths are cleared out.