New packages py-regionmask, py-pyogrio; add py-geopandas versions 1.0.0 and 1.0.1#46209
Merged
scheibelp merged 7 commits intospack:developfrom Sep 11, 2024
Merged
Conversation
spackbot-app
bot
added
dependencies
new-package
new-version
python
update-package
labels
adamjstewart
reviewed
Sep 5, 2024
Member
adamjstewart
left a comment
adamjstewart
left a comment
There was a problem hiding this comment.
Only reviewed geopandas but it mostly looks good
adamjstewart
approved these changes
Sep 5, 2024
Member
adamjstewart
left a comment
adamjstewart
left a comment
There was a problem hiding this comment.
Geopandas looks good to me now, will let someone else review the other packages
scheibelp
approved these changes
Sep 11, 2024
Member
scheibelp
left a comment
scheibelp
left a comment
There was a problem hiding this comment.
I have a question and a suggestion for the future (neither should hold this PR up). I'll collapse the comments (our policy requires this for merge) but if you get a chance to respond, that would be great.
Contributor
Author
|
Thanks @scheibelp ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is primarily to add a new package
py-regionmaskused for creating masks of geospatial regions for arbitrary grids. The package depends onpy-pyogrio, which is added as a new package as well. It also requires a newer version ofpy-geopandas(not explicitly, but implicitly:py-regionmaskdepends onpy-shapely@2:, but older versions ofpy-geopandasdepend onpy-shapely@:1).I tested building those packages on Oracle Linux 9.1 with
[email protected]and going through the plotting tutorial https://regionmask.readthedocs.io/en/stable/notebooks/plotting.html.