Skip to content

sfcio: add v1.4.2#46146

Merged
wdconinc merged 2 commits intospack:developfrom
AlexanderRichert-NOAA:patch-16
Aug 31, 2024
Merged

sfcio: add v1.4.2#46146
wdconinc merged 2 commits intospack:developfrom
AlexanderRichert-NOAA:patch-16

Conversation

@AlexanderRichert-NOAA
Copy link
Copy Markdown
Contributor

Add v1.4.2 for sfcio, which adds Intel oneAPI support. No other variant changes etc.

@AlexanderRichert-NOAA
Copy link
Copy Markdown
Contributor Author

@spackbot fix style

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Aug 30, 2024

Let me see if I can fix that for you!

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Aug 30, 2024

I was able to run spack style --fix for you!

spack style --fix
==> Running style checks on spack
  selected: isort, black, flake8, mypy
==> Modified files
  var/spack/repos/builtin/packages/sfcio/package.py
==> Running isort checks
  isort checks were clean
==> Running black checks
reformatted var/spack/repos/builtin/packages/sfcio/package.py
All done! ✨ 🍰 ✨
1 file reformatted.
  black checks were clean
==> Running flake8 checks
  flake8 checks were clean
==> Running mypy checks
lib/spack/spack/version/version_types.py:145: error: Argument 2 to "StandardVersion" has incompatible type "*Tuple[Tuple[Any, ...], Tuple[Any, ...]]"; expected "Tuple[Tuple[Any, ...], Tuple[Any, ...]]"  [arg-type]
lib/spack/spack/version/version_types.py:452: error: Argument 2 to "StandardVersion" has incompatible type "*Tuple[Tuple[Any, ...], Tuple[Any, ...]]"; expected "Tuple[Tuple[Any, ...], Tuple[Any, ...]]"  [arg-type]
lib/spack/spack/version/version_types.py:481: error: Argument 2 to "StandardVersion" has incompatible type "*Tuple[Tuple[Any, ...], Tuple[Any, ...]]"; expected "Tuple[Tuple[Any, ...], Tuple[Any, ...]]"  [arg-type]
Found 3 errors in 1 file (checked 620 source files)
  mypy found errors
Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. If I was able to push to your branch, if you make further changes you will need to pull from your updated branch before pushing again.

I've updated the branch with style fixes.

@wdconinc wdconinc self-assigned this Aug 31, 2024
@wdconinc wdconinc merged commit 8cac746 into spack:develop Aug 31, 2024
@wdconinc
Copy link
Copy Markdown
Contributor

Forgot to note that I verified the hash.

AlexanderRichert-NOAA added a commit to AlexanderRichert-NOAA/spack that referenced this pull request Sep 3, 2024
* sfcio: add v1.4.2

* [@spackbot] updating style on behalf of AlexanderRichert-NOAA
AlexanderRichert-NOAA added a commit to AlexanderRichert-NOAA/spack that referenced this pull request Oct 23, 2024
* sfcio: add v1.4.2

* [@spackbot] updating style on behalf of AlexanderRichert-NOAA
AlexanderRichert-NOAA added a commit to JCSDA/spack that referenced this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants