Skip to content

Fix linking for python with external ncurses #45803

Merged
alalazo merged 2 commits intospack:developfrom
s-sajid-ali:fix_ncurses_python
Aug 20, 2024
Merged

Fix linking for python with external ncurses #45803
alalazo merged 2 commits intospack:developfrom
s-sajid-ali:fix_ncurses_python

Conversation

@s-sajid-ali
Copy link
Copy Markdown
Contributor

@s-sajid-ali s-sajid-ali commented Aug 17, 2024

Trimmed down version of #44226

@spackbot-app spackbot-app bot requested review from scheibelp and skosukhin August 17, 2024 18:50
@teaguesterling teaguesterling mentioned this pull request Aug 17, 2024
Closed
@teaguesterling
Copy link
Copy Markdown
Contributor

teaguesterling commented Aug 17, 2024

FYI this solution fixed the issue as it presented in #45083. I've modified that PR to utilize this fix (and thus shouldn't be merged until this is).

alalazo
alalazo requested changes Aug 19, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@alalazo alalazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a failure in pipelines: https://gitlab.spack.io/spack/spack/-/jobs/12268196

@s-sajid-ali
Copy link
Copy Markdown
Contributor Author

s-sajid-ali commented Aug 19, 2024

The failure for gloo build in the pipeline is coming from the -- Detecting C compiler ABI info cmake phase (https://gitlab.spack.io/spack/spack/-/jobs/12268196#L156).

Unsure how a Python recipe is affecting gloo since python is not a dependency of gloo per: https://packages.spack.io/package.html?name=gloo

@teaguesterling
Copy link
Copy Markdown
Contributor

teaguesterling commented Aug 19, 2024

Might just be worth rerunning the pipeline. Occasionally, these sorts of errors seem to pop up and can be fixed by asking spackbot to try again.

@teaguesterling
Copy link
Copy Markdown
Contributor

teaguesterling commented Aug 20, 2024

@spackbot rerun pipeline

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Aug 20, 2024

I've started that pipeline for you!

@alalazo alalazo merged commit 9d0b9f0 into spack:develop Aug 20, 2024
@s-sajid-ali s-sajid-ali deleted the fix_ncurses_python branch August 20, 2024 14:28
@s-sajid-ali s-sajid-ali mentioned this pull request Aug 20, 2024
Closed
@greenc-FNAL greenc-FNAL mentioned this pull request Aug 22, 2024
Merged
FrederickDeny pushed a commit to FrederickDeny/spack that referenced this pull request Aug 26, 2024
@s-sajid-ali @adamjstewart @FrederickDeny
Fix linking for python with external ncurses (spack#45803)
5089aad 
Co-authored-by: Adam J. Stewart <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalazo alalazo alalazo approved these changes

@scheibelp scheibelp Awaiting requested review from scheibelp

@skosukhin skosukhin Awaiting requested review from skosukhin

Assignees

No one assigned

Labels

python update-package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@s-sajid-ali @teaguesterling @alalazo