Update ESMF: add missing python/py-pyyaml dependency since 8.4.0#45700
Update ESMF: add missing python/py-pyyaml dependency since 8.4.0#45700climbfuji wants to merge 1 commit intospack:developfrom
Conversation
@danrosen25 - do you know specifics about versions required by ESMX? Thanks. |
|
ESMX is code only and doesn't get built until the end user executes a build command using ESMX. I don't know specific version requirements for python and py-pyaml. I recommend using the current default spack versions and then we can test the spack installation in a container. My system is using the following
GitHub runners are using the following
ESMF Docker Container
|
|
Thanks, py-pyyaml@6 is available in spack and used in our environments. To be on the safe side, should I pin python to |
|
If you give me the exact default versions for spack then I'll test them out in a container but it will take some time for me to get to the testing. |
Default for python is 3.11.7, and for py-pyyaml 6.0.1 |
|
On my local system I use ESMX successfully with |
|
Perfect, then this is ready ;-) |
theurich
left a comment
There was a problem hiding this comment.
Looks good to me. Thank you for getting these run-time dependencies set correctly!
|
And if you're looking for minimums as opposed to defaults then Gerhard wins with the earliest versions that we've tested.
|
|
These changes have been pulled into #45504 - closing. Thanks for your feedback! |
In
[email protected], theesmxtool was added and it looks like it is always built (i.e. no optional component/variant):https://github.com/esmf-org/esmf/blob/v8.4.0/makefile
esmxdepends onpy-pyyaml(and thereforepython) at runtime. The minimum Python version in spack is 3.7, and lacking any further information on the Python requirements foresmx(see https://earthsystemmodeling.org/docs/nightly/develop/ESMF_usrdoc), I simply addedpythonandpy-pyyamlas dependencies.If any of the ESMF developers knows better which versions of
pythonandpy-pyyamlare required, please let me know!Update Based on the exchange below, the minimum versions in spack are safe options, and so are the current defaults. Therefore, not specifying any version constraints.