Merged
Conversation
alalazo
approved these changes
Aug 12, 2024
diehlpk
pushed a commit
to diehlpk/spack
that referenced
this pull request
Aug 14, 2024
Chrismarsh
pushed a commit
to Chrismarsh/spack
that referenced
this pull request
Aug 16, 2024
tldahlgren
pushed a commit
to AcriusWinter/spack
that referenced
this pull request
Aug 20, 2024
FrederickDeny
pushed a commit
to FrederickDeny/spack
that referenced
this pull request
Aug 26, 2024
haampie
added a commit
that referenced
this pull request
Sep 21, 2024
haampie
added a commit
that referenced
this pull request
Sep 21, 2024
haampie
added a commit
that referenced
this pull request
Sep 21, 2024
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
urllib(or ratherssl.py) can throwTimeoutError, which is not caught in various places, causing the error to be fatal.See for example https://gitlab.spack.io/spack/spack/-/jobs/12182279.