Add full_hostname host variable#45522
Merged
bernhardkaindl merged 2 commits intospack:developfrom Aug 28, 2024
Merged
Conversation
Contributor
bernhardkaindl
left a comment
bernhardkaindl
left a comment
There was a problem hiding this comment.
This change also affects the
hostnamefield in theinstall_environment.jsonfile.
+ "full_hostname": socket.getfqdn(),instead of
- "hostname": socket.gethostname(),
+ "hostname": socket.getfqdn(),The former would not break any existing environments, I think?
Jordan474
force-pushed
the
hostname-is-fqdn
branch
from
5b14918 to
97e323b
Compare
Makes fully qualified hostname available as `full_hostname` variable in `when: ` conditions, and saved in install metadata.
Jordan474
force-pushed
the
hostname-is-fqdn
branch
from
97e323b to
c76df33
Compare
Jordan474
changed the title
spackbot-app
bot
added
the
documentation
Contributor
Author
|
Changed it to Also updated the doc, which was outdated: spack doesn't use |
bernhardkaindl
approved these changes
Aug 28, 2024
Contributor
bernhardkaindl
left a comment
bernhardkaindl
left a comment
There was a problem hiding this comment.
As far as I can see, this looks safe now.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the fully qualified hostname available as
full_hostnamevariable inwhen:conditions.This allows you to test against the site's domain name, rather than just the hostname.
This change also adds
full_hostnamefield in theinstall_environment.jsonfile.