wasi-sdk-prebuilt: new package#45394
Merged
tldahlgren merged 2 commits intospack:developfrom Jul 25, 2024
Merged
Conversation
Signed-off-by: Teague Sterling <[email protected]>
Closed
tldahlgren
approved these changes
Jul 23, 2024
tldahlgren
requested changes
Jul 23, 2024
Contributor
tldahlgren
left a comment
tldahlgren
left a comment
There was a problem hiding this comment.
Group methods together after properties and directives.
tldahlgren
approved these changes
Jul 25, 2024
tgamblin
added a commit
that referenced
this pull request
Jul 29, 2024
This was missed in #45394 because we don't run unit tests for package PRs, and `test_all_virtual_packages_have_default_providers`, which would've caught it, is a unit test, not an audit. - [x] add a default provider for `wasi-sdk` in `etc/spack/defaults/packages.yaml` (which we require for all virtuals) - [x] rework `test_all_virtual_packages_have_default_providers` as an audit called `_ensure_all_virtual_packages_have_default_providers` Signed-off-by: Todd Gamblin <[email protected]>
3 tasks
tgamblin
added a commit
that referenced
this pull request
Jul 29, 2024
This was missed in #45394 because we don't run unit tests for package PRs, and `test_all_virtual_packages_have_default_providers`, which would've caught it, is a unit test, not an audit. - [x] add a default provider for `wasi-sdk` in `etc/spack/defaults/packages.yaml` (which we require for all virtuals) - [x] rework `test_all_virtual_packages_have_default_providers` as an audit called `_ensure_all_virtual_packages_have_default_providers` Signed-off-by: Todd Gamblin <[email protected]>
tgamblin
added a commit
that referenced
this pull request
Jul 29, 2024
This was missed in #45394 because we don't run unit tests for package PRs, and `test_all_virtual_packages_have_default_providers`, which would've caught it, is a unit test, not an audit. - [x] add a default provider for `wasi-sdk` in `etc/spack/defaults/packages.yaml` (which we require for all virtuals) - [x] rework `test_all_virtual_packages_have_default_providers` as an audit called `_ensure_all_virtual_packages_have_default_providers` Signed-off-by: Todd Gamblin <[email protected]>
tgamblin
added a commit
that referenced
this pull request
Jul 29, 2024
This was missed in #45394 because we don't run unit tests for package PRs, and `test_all_virtual_packages_have_default_providers`, which would've caught it, is a unit test, not an audit. - [x] add a default provider for `wasi-sdk` in `etc/spack/defaults/packages.yaml` (which we require for all virtuals) - [x] rework `test_all_virtual_packages_have_default_providers` as an audit called `_ensure_all_virtual_packages_have_default_providers` Signed-off-by: Todd Gamblin <[email protected]>
johnwparent
pushed a commit
to johnwparent/spack
that referenced
this pull request
Aug 2, 2024
* wasi-sdk-prebuilt: new package * move url_for_version to be first method --------- Signed-off-by: Teague Sterling <[email protected]>
johnwparent
pushed a commit
to johnwparent/spack
that referenced
this pull request
Aug 2, 2024
This was missed in spack#45394 because we don't run unit tests for package PRs, and `test_all_virtual_packages_have_default_providers`, which would've caught it, is a unit test, not an audit. - [x] add a default provider for `wasi-sdk` in `etc/spack/defaults/packages.yaml` (which we require for all virtuals) - [x] rework `test_all_virtual_packages_have_default_providers` as an audit called `_ensure_all_virtual_packages_have_default_providers` Signed-off-by: Todd Gamblin <[email protected]>
diehlpk
pushed a commit
to diehlpk/spack
that referenced
this pull request
Aug 14, 2024
* wasi-sdk-prebuilt: new package * move url_for_version to be first method --------- Signed-off-by: Teague Sterling <[email protected]>
diehlpk
pushed a commit
to diehlpk/spack
that referenced
this pull request
Aug 14, 2024
This was missed in spack#45394 because we don't run unit tests for package PRs, and `test_all_virtual_packages_have_default_providers`, which would've caught it, is a unit test, not an audit. - [x] add a default provider for `wasi-sdk` in `etc/spack/defaults/packages.yaml` (which we require for all virtuals) - [x] rework `test_all_virtual_packages_have_default_providers` as an audit called `_ensure_all_virtual_packages_have_default_providers` Signed-off-by: Todd Gamblin <[email protected]>
Chrismarsh
pushed a commit
to Chrismarsh/spack
that referenced
this pull request
Aug 16, 2024
This was missed in spack#45394 because we don't run unit tests for package PRs, and `test_all_virtual_packages_have_default_providers`, which would've caught it, is a unit test, not an audit. - [x] add a default provider for `wasi-sdk` in `etc/spack/defaults/packages.yaml` (which we require for all virtuals) - [x] rework `test_all_virtual_packages_have_default_providers` as an audit called `_ensure_all_virtual_packages_have_default_providers` Signed-off-by: Todd Gamblin <[email protected]>
tldahlgren
pushed a commit
to AcriusWinter/spack
that referenced
this pull request
Aug 20, 2024
* wasi-sdk-prebuilt: new package * move url_for_version to be first method --------- Signed-off-by: Teague Sterling <[email protected]>
tldahlgren
pushed a commit
to AcriusWinter/spack
that referenced
this pull request
Aug 20, 2024
This was missed in spack#45394 because we don't run unit tests for package PRs, and `test_all_virtual_packages_have_default_providers`, which would've caught it, is a unit test, not an audit. - [x] add a default provider for `wasi-sdk` in `etc/spack/defaults/packages.yaml` (which we require for all virtuals) - [x] rework `test_all_virtual_packages_have_default_providers` as an audit called `_ensure_all_virtual_packages_have_default_providers` Signed-off-by: Todd Gamblin <[email protected]>
FrederickDeny
pushed a commit
to FrederickDeny/spack
that referenced
this pull request
Aug 26, 2024
* wasi-sdk-prebuilt: new package * move url_for_version to be first method --------- Signed-off-by: Teague Sterling <[email protected]>
FrederickDeny
pushed a commit
to FrederickDeny/spack
that referenced
this pull request
Aug 26, 2024
This was missed in spack#45394 because we don't run unit tests for package PRs, and `test_all_virtual_packages_have_default_providers`, which would've caught it, is a unit test, not an audit. - [x] add a default provider for `wasi-sdk` in `etc/spack/defaults/packages.yaml` (which we require for all virtuals) - [x] rework `test_all_virtual_packages_have_default_providers` as an audit called `_ensure_all_virtual_packages_have_default_providers` Signed-off-by: Todd Gamblin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a version of the wasi-sdk that is precompiled into WASM. However, ideally this would be compiled on-demand.