cbindgen: new package plus 1 dependency package by teaguesterling · Pull Request #45393 · spack/spack

teaguesterling · 2024-07-23T05:54:09Z

No description provided.

Signed-off-by: Teague Sterling <[email protected]>

tldahlgren

Confirmed the homepage and version sha256s but confused about the commented out dependencies.

var/spack/repos/builtin/packages/cbindgen/package.py

teaguesterling · 2024-07-25T01:23:13Z

Whoops! Thanks for catching that. Looks like this one wasn't really ready to go. Will review and fix.

Signed-off-by: Teague Sterling <[email protected]>

tldahlgren

Confirmed homepages, version sha256s, and commits.

tldahlgren · 2024-07-25T21:10:47Z

@spackbot fix style

spackbot-app · 2024-07-25T21:10:50Z

Let me see if I can fix that for you!

spackbot-app · 2024-07-25T21:12:04Z

I was able to run spack style --fix for you!

spack style --fix

==> Running style checks on spack
  selected: isort, black, flake8, mypy
==> Modified files
  var/spack/repos/builtin/packages/cbindgen/package.py
  var/spack/repos/builtin/packages/rust-clap/package.py
  var/spack/repos/builtin/packages/rust-heck/package.py
  var/spack/repos/builtin/packages/rust-indexmap/package.py
  var/spack/repos/builtin/packages/rust-log/package.py
  var/spack/repos/builtin/packages/rust-proc-macro2/package.py
  var/spack/repos/builtin/packages/rust-serde-json/package.py
  var/spack/repos/builtin/packages/rust-serde/package.py
  var/spack/repos/builtin/packages/rust-toml/package.py
==> Running isort checks
  isort checks were clean
==> Running black checks
reformatted var/spack/repos/builtin/packages/rust-heck/package.py
reformatted var/spack/repos/builtin/packages/rust-indexmap/package.py
reformatted var/spack/repos/builtin/packages/rust-clap/package.py
reformatted var/spack/repos/builtin/packages/rust-proc-macro2/package.py
reformatted var/spack/repos/builtin/packages/rust-log/package.py
reformatted var/spack/repos/builtin/packages/rust-serde-json/package.py
reformatted var/spack/repos/builtin/packages/rust-serde/package.py
reformatted var/spack/repos/builtin/packages/rust-toml/package.py
All done! ✨ 🍰 ✨
8 files reformatted, 1 file left unchanged.
  black checks were clean
==> Running flake8 checks
var/spack/repos/builtin/packages/rust-indexmap/package.py:9: [E501] line too long (102 > 99 characters)
var/spack/repos/builtin/packages/rust-proc-macro2/package.py:9: [E501] line too long (142 > 99 characters)
  flake8 found errors
==> Running mypy checks
lib/spack/spack/version/version_types.py:145: error: Argument 2 to "StandardVersion" has incompatible type "*Tuple[Tuple[Any, ...], Tuple[Any, ...]]"; expected "Tuple[Tuple[Any, ...], Tuple[Any, ...]]"  [arg-type]
lib/spack/spack/version/version_types.py:452: error: Argument 2 to "StandardVersion" has incompatible type "*Tuple[Tuple[Any, ...], Tuple[Any, ...]]"; expected "Tuple[Tuple[Any, ...], Tuple[Any, ...]]"  [arg-type]
lib/spack/spack/version/version_types.py:481: error: Argument 2 to "StandardVersion" has incompatible type "*Tuple[Tuple[Any, ...], Tuple[Any, ...]]"; expected "Tuple[Tuple[Any, ...], Tuple[Any, ...]]"  [arg-type]
Found 3 errors in 1 file (checked 621 source files)
  mypy found errors

Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. If I was able to push to your branch, if you make further changes you will need to pull from your updated branch before pushing again.

I've updated the branch with style fixes.

tldahlgren

See comment

var/spack/repos/builtin/packages/rust-indexmap/package.py

teaguesterling · 2024-07-27T01:13:01Z

@spackbot fix style

spackbot-app · 2024-07-27T01:13:03Z

Let me see if I can fix that for you!

spackbot-app · 2024-07-27T01:14:16Z

I was able to run spack style --fix for you!

spack style --fix

==> Running style checks on spack
  selected: isort, black, flake8, mypy
==> Modified files
  var/spack/repos/builtin/packages/cbindgen/package.py
  var/spack/repos/builtin/packages/rust-clap/package.py
  var/spack/repos/builtin/packages/rust-heck/package.py
  var/spack/repos/builtin/packages/rust-indexmap/package.py
  var/spack/repos/builtin/packages/rust-log/package.py
  var/spack/repos/builtin/packages/rust-proc-macro2/package.py
  var/spack/repos/builtin/packages/rust-serde-json/package.py
  var/spack/repos/builtin/packages/rust-serde/package.py
  var/spack/repos/builtin/packages/rust-toml/package.py
==> Running isort checks
  isort checks were clean
==> Running black checks
All done! ✨ 🍰 ✨
9 files left unchanged.
  black checks were clean
==> Running flake8 checks
var/spack/repos/builtin/packages/rust-indexmap/package.py:9: [E501] line too long (102 > 99 characters)
var/spack/repos/builtin/packages/rust-proc-macro2/package.py:9: [E501] line too long (142 > 99 characters)
  flake8 found errors
==> Running mypy checks
lib/spack/spack/version/version_types.py:145: error: Argument 2 to "StandardVersion" has incompatible type "*Tuple[Tuple[Any, ...], Tuple[Any, ...]]"; expected "Tuple[Tuple[Any, ...], Tuple[Any, ...]]"  [arg-type]
lib/spack/spack/version/version_types.py:452: error: Argument 2 to "StandardVersion" has incompatible type "*Tuple[Tuple[Any, ...], Tuple[Any, ...]]"; expected "Tuple[Tuple[Any, ...], Tuple[Any, ...]]"  [arg-type]
lib/spack/spack/version/version_types.py:481: error: Argument 2 to "StandardVersion" has incompatible type "*Tuple[Tuple[Any, ...], Tuple[Any, ...]]"; expected "Tuple[Tuple[Any, ...], Tuple[Any, ...]]"  [arg-type]
Found 3 errors in 1 file (checked 621 source files)
  mypy found errors

Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. If I was able to push to your branch, if you make further changes you will need to pull from your updated branch before pushing again.

I wasn't able to make any further changes, but please see the message above for remaining issues you can fix locally!

Signed-off-by: Teague Sterling <[email protected]>

tldahlgren · 2024-08-05T20:25:13Z

Please resolve the flake8 issues:

...
  black checks were clean
==> Running flake8 checks
var/spack/repos/builtin/packages/rust-indexmap/package.py:9: [E501] line too long (102 > 99 characters)
var/spack/repos/builtin/packages/rust-proc-macro2/package.py:9: [E501] line too long (142 > 99 characters)
  flake8 found errors
...

teaguesterling · 2024-08-05T21:28:31Z

I'm going to move this back to draft unless we want to clean it up and include as-is. There are a lot of rust dependencies that are not yet in Spack and it's a bit of a rabbit hole (see #45483).

Happy to prep this for merging if you agree (to enable Firefox, for example). I wanted to be transparent about the lingering unadressed dependencies in the Rust ecosystem.

tldahlgren · 2024-08-06T01:08:08Z

I'm going to move this back to draft unless we want to clean it up and include as-is. There are a lot of rust dependencies that are not yet in Spack and it's a bit of a rabbit hole (see #45483).

Happy to prep this for merging if you agree (to enable Firefox, for example). I wanted to be transparent about the lingering unadressed dependencies in the Rust ecosystem.

As long as it doesn't break other builds, it's up to you. Just let me know what you want to do.

Signed-off-by: Teague Sterling <[email protected]>

teaguesterling · 2024-08-07T03:54:58Z

I'm going to move this back to draft unless we want to clean it up and include as-is. There are a lot of rust dependencies that are not yet in Spack and it's a bit of a rabbit hole (see #45483).
Happy to prep this for merging if you agree (to enable Firefox, for example). I wanted to be transparent about the lingering unadressed dependencies in the Rust ecosystem.

As long as it doesn't break other builds, it's up to you. Just let me know what you want to do.

I've removed some of the dependencies here. After poking around a bit I think there's more work needed to properly model the rust library dependencies in Spack.

Signed-off-by: Teague Sterling <[email protected]>

bernhardkaindl

CI passes, Built on Ubuntu 22.04:

@tldahlgren, can you retract your "changes requested" status?

cbindgen: new package

596af3f

Signed-off-by: Teague Sterling <[email protected]>

spackbot-app bot added dependencies new-package new-version labels Jul 23, 2024

teaguesterling mentioned this pull request Jul 23, 2024

firefox: new package #45083

Closed

tldahlgren reviewed Jul 23, 2024

View reviewed changes

var/spack/repos/builtin/packages/cbindgen/package.py Outdated Show resolved Hide resolved

tldahlgren self-assigned this Jul 23, 2024

tldahlgren added the question label Jul 23, 2024

Attempting to add rust dependencies for cbindgen

c9b6f95

Signed-off-by: Teague Sterling <[email protected]>

spackbot-app bot added the new-variant label Jul 25, 2024

tldahlgren changed the title ~~cbindgen: new package~~ cbindgen: new package plus 8 dependency packages Jul 25, 2024

tldahlgren previously approved these changes Jul 25, 2024

View reviewed changes

[@spackbot] updating style on behalf of teaguesterling

608fa2a

spackbot dismissed tldahlgren’s stale review via 608fa2a July 25, 2024 21:12

tldahlgren requested changes Jul 25, 2024

View reviewed changes

var/spack/repos/builtin/packages/rust-indexmap/package.py Outdated Show resolved Hide resolved

Update package.py

3d7145c

adding rust-toml min rust version

d54f31c

Signed-off-by: Teague Sterling <[email protected]>

teaguesterling added 3 commits August 6, 2024 20:46

Removing dependencies that don't install with cargo

bbcb3f4

Cleaning up

ae4beaa

Signed-off-by: Teague Sterling <[email protected]>

cleanup broken packages

333b94c

Signed-off-by: Teague Sterling <[email protected]>

Fixing styles

7ec1f53

Signed-off-by: Teague Sterling <[email protected]>

teaguesterling changed the title ~~cbindgen: new package plus 8 dependency packages~~ cbindgen: new package plus 1 dependency package Aug 7, 2024

teaguesterling requested a review from tldahlgren August 9, 2024 19:31

spack deleted a comment from spackbot-app bot Sep 28, 2024

bernhardkaindl approved these changes Sep 28, 2024

View reviewed changes

bernhardkaindl self-assigned this Sep 28, 2024

tldahlgren approved these changes Sep 30, 2024

View reviewed changes

tldahlgren merged commit cb43019 into spack:develop Sep 30, 2024

Conversation

teaguesterling commented Jul 23, 2024

Uh oh!

tldahlgren left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

teaguesterling commented Jul 25, 2024

Uh oh!

tldahlgren left a comment

Choose a reason for hiding this comment

Uh oh!

tldahlgren commented Jul 25, 2024

Uh oh!

spackbot-app bot commented Jul 25, 2024

Uh oh!

spackbot-app bot commented Jul 25, 2024

Uh oh!

tldahlgren left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

teaguesterling commented Jul 27, 2024

Uh oh!

spackbot-app bot commented Jul 27, 2024

Uh oh!

spackbot-app bot commented Jul 27, 2024

Uh oh!

tldahlgren commented Aug 5, 2024

Uh oh!

teaguesterling commented Aug 5, 2024

Uh oh!

tldahlgren commented Aug 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

teaguesterling commented Aug 7, 2024

Uh oh!

bernhardkaindl left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tldahlgren commented Aug 6, 2024 •

edited

Loading