Skip to content

add pkg- prefix to builtin.mock a b c d ...#45205

Merged
alalazo merged 1 commit intodevelopfrom
hs/fix/test-single-letter-pkgs
Jul 12, 2024
Merged

add pkg- prefix to builtin.mock a b c d ...#45205
alalazo merged 1 commit intodevelopfrom
hs/fix/test-single-letter-pkgs

Conversation

@haampie
Copy link
Copy Markdown
Member

@haampie haampie commented Jul 12, 2024

No description provided.

@spackbot-app spackbot-app bot added commands conflicts core PR affects Spack core functionality dependencies tests General test capability(ies) labels Jul 12, 2024
@haampie haampie force-pushed the hs/fix/test-single-letter-pkgs branch from 1b2a99e to 84d58df Compare July 12, 2024 08:15
Copy link
Copy Markdown
Member

@alalazo alalazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, much needed and tedious to do 🙏

@alalazo alalazo merged commit 9c8846b into develop Jul 12, 2024
@alalazo alalazo deleted the hs/fix/test-single-letter-pkgs branch July 12, 2024 09:27
tldahlgren added a commit to nhanford/spack that referenced this pull request Jul 17, 2024
diehlpk pushed a commit to diehlpk/spack that referenced this pull request Aug 14, 2024
@haampie haampie mentioned this pull request Aug 20, 2024
26 tasks
@haampie haampie mentioned this pull request Aug 20, 2024
14 tasks
FrederickDeny pushed a commit to FrederickDeny/spack that referenced this pull request Aug 26, 2024
alalazo added a commit to alalazo/spack that referenced this pull request Sep 30, 2024
spack#45205 already removed previous use of single letter packages
from unit tests, in view of reserving `c` as a language (see spack#45191).

Some use of them has been re-introduced accidentally in spack#46382, and
is making unit-tests fail in the feature branch spack#45189 since there
`c` is a virtual package.

Signed-off-by: Massimiliano Culpo <[email protected]>
tldahlgren pushed a commit that referenced this pull request Oct 1, 2024
#45205 already removed previous use of single letter packages
from unit tests, in view of reserving `c` as a language (see #45191).

Some use of them has been re-introduced accidentally in #46382, and
is making unit-tests fail in the feature branch #45189 since there
`c` is a virtual package.

Signed-off-by: Massimiliano Culpo <[email protected]>
arezaii pushed a commit to arezaii/spack that referenced this pull request Oct 22, 2024
spack#45205 already removed previous use of single letter packages
from unit tests, in view of reserving `c` as a language (see spack#45191).

Some use of them has been re-introduced accidentally in spack#46382, and
is making unit-tests fail in the feature branch spack#45189 since there
`c` is a virtual package.

Signed-off-by: Massimiliano Culpo <[email protected]>
vjranagit pushed a commit to vjranagit/spack that referenced this pull request Jan 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commands conflicts core PR affects Spack core functionality dependencies tests General test capability(ies)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants