Skip to content

directives.py: reserve c, cxx, fortran in depends_on#45191

Merged
alalazo merged 1 commit intodevelopfrom
hs/feature/depends-on-reserve-language-virtuals
Jul 12, 2024
Merged

directives.py: reserve c, cxx, fortran in depends_on#45191
alalazo merged 1 commit intodevelopfrom
hs/feature/depends-on-reserve-language-virtuals

Conversation

@haampie
Copy link
Copy Markdown
Member

@haampie haampie commented Jul 11, 2024

No description provided.

@spackbot-app spackbot-app bot added core PR affects Spack core functionality directives commands conflicts dependencies tests General test capability(ies) labels Jul 11, 2024
@haampie haampie force-pushed the hs/feature/depends-on-reserve-language-virtuals branch from e080c1a to 737ce75 Compare July 11, 2024 13:36
@haampie haampie force-pushed the hs/feature/depends-on-reserve-language-virtuals branch from 737ce75 to 5add2af Compare July 12, 2024 08:02
@haampie haampie force-pushed the hs/feature/depends-on-reserve-language-virtuals branch from 5add2af to 575f018 Compare July 12, 2024 10:02
@alalazo alalazo merged commit 0ce35da into develop Jul 12, 2024
@alalazo alalazo deleted the hs/feature/depends-on-reserve-language-virtuals branch July 12, 2024 13:25
diehlpk pushed a commit to diehlpk/spack that referenced this pull request Aug 14, 2024
haampie added a commit that referenced this pull request Aug 20, 2024
@haampie haampie mentioned this pull request Aug 20, 2024
26 tasks
FrederickDeny pushed a commit to FrederickDeny/spack that referenced this pull request Aug 26, 2024
haampie added a commit that referenced this pull request Sep 21, 2024
alalazo added a commit to alalazo/spack that referenced this pull request Sep 30, 2024
spack#45205 already removed previous use of single letter packages
from unit tests, in view of reserving `c` as a language (see spack#45191).

Some use of them has been re-introduced accidentally in spack#46382, and
is making unit-tests fail in the feature branch spack#45189 since there
`c` is a virtual package.

Signed-off-by: Massimiliano Culpo <[email protected]>
tldahlgren pushed a commit that referenced this pull request Oct 1, 2024
#45205 already removed previous use of single letter packages
from unit tests, in view of reserving `c` as a language (see #45191).

Some use of them has been re-introduced accidentally in #46382, and
is making unit-tests fail in the feature branch #45189 since there
`c` is a virtual package.

Signed-off-by: Massimiliano Culpo <[email protected]>
arezaii pushed a commit to arezaii/spack that referenced this pull request Oct 22, 2024
spack#45205 already removed previous use of single letter packages
from unit tests, in view of reserving `c` as a language (see spack#45191).

Some use of them has been re-introduced accidentally in spack#46382, and
is making unit-tests fail in the feature branch spack#45189 since there
`c` is a virtual package.

Signed-off-by: Massimiliano Culpo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commands conflicts core PR affects Spack core functionality dependencies directives tests General test capability(ies)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants