Merged
Conversation
spackbot-app
bot
added
commands
core
1. Avoid that `self.path` is of type `Optional[str]` 2. Simplify immutable config with a property.
haampie
force-pushed
the
hs/fix/config-class-hierarchy
branch
from
7565bca to
7ce83c1
Compare
haampie
force-pushed
the
hs/fix/config-class-hierarchy
branch
from
d185846 to
6405b04
Compare
alalazo
previously approved these changes
Jul 5, 2024
Member
alalazo
left a comment
alalazo
left a comment
There was a problem hiding this comment.
Basically LGTM. A few minor suggestions on having keyword only args for at least added arguments, if you feel like it.
alalazo
approved these changes
Jul 5, 2024
hariharan-devarajan
pushed a commit
to hariharan-devarajan/spack
that referenced
this pull request
Jul 10, 2024
1. Avoid that `self.path` is of type `Optional[str]` 2. Simplify immutable config with a property.
psakievich
added a commit
to sandialabs/spack-manager
that referenced
this pull request
Jul 16, 2024
Address changes to spack environments and scopes See: - spack/spack#45044 - spack/spack#45135
psakievich
added a commit
to sandialabs/spack-manager
that referenced
this pull request
Jul 16, 2024
Address changes to spack environments and scopes See: - spack/spack#45044 - spack/spack#45135
psakievich
added a commit
to sandialabs/spack-manager
that referenced
this pull request
Jul 16, 2024
* Fixes for changes in core spack Address changes to spack environments and scopes See: - spack/spack#45044 - spack/spack#45135 * Fixes * Style ci * Style
FrederickDeny
pushed a commit
to FrederickDeny/spack
that referenced
this pull request
Aug 26, 2024
1. Avoid that `self.path` is of type `Optional[str]` 2. Simplify immutable config with a property.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
self.pathis of typeOptional[str]: file based config extends non-file based config now.The idea is to be able to construct
EnvironmentManifest(path)and mark every associated config scope as non-writable, which is useful for a featurespack -C <env> <command>.