spack compiler find: write into packages.yaml#44419
spack compiler find: write into packages.yaml#44419alalazo wants to merge 13 commits intospack:developfrom
Conversation
39786ab to
26c2956
Compare
26c2956 to
f083170
Compare
|
It seems these compilers are detected on Windows: packages:
llvm:
externals:
- spec: [email protected]+clang+lld~lldb
prefix: C:\Program Files\LLVM
extra_attributes:
compilers:
c: C:\Program Files\LLVM\bin\clang.exe
cxx: C:\Program Files\LLVM\bin\clang++.exe
ld: C:\Program Files\LLVM\bin\ld.lld.exe
gcc:
externals:
- spec: [email protected] languages='c,c++,fortran'
prefix: C:\Strawberry\c
extra_attributes:
compilers:
c: C:\Strawberry\c\bin\gcc.exe
cxx: C:\Strawberry\c\bin\g++.exe
fortran: C:\Strawberry\c\bin\gfortran.exe
- spec: [email protected] languages='c,c++,fortran'
prefix: C:\mingw64
extra_attributes:
compilers:
c: C:\mingw64\bin\gcc.exe
cxx: C:\mingw64\bin\g++.exe
fortran: C:\mingw64\bin\gfortran.exe |
|
Apparently one needs to source: to get compilers in PATH on |
ab4bfd7 to
2291267
Compare
039258b to
b06addc
Compare
|
Why is |
Not part of this PR. It's the external search logic in LLVM that finds it. |
This commit makes spack compiler find write in packages.yaml, instead of compilers.yaml.
This excludes, e.g. llvm~clang etc. if found
add_compilers_to_config is not called anymore
0583081 to
7da4308
Compare
Extracted from spack#44419 This adds / modifies some external detection tests for compilers, to reproduce cases that are currently tested in unit tests. The unit tests will later be removed.
Extracted from spack#44419 This adds / modifies some external detection tests for compilers, to reproduce cases that are currently tested in unit tests. The unit tests will later be removed.
|
I have some questions. How will mixed toolchains be accounted for? Say I have a compiler that only supplies Seems like the former will work for many cases and meets some of my requests for a concise way to represent a tool chain. However, it feels really hacky and also seems super limited. The latter is really verbose, but also very clear. Anything in the middle seems scary like Anyways what's the correct syntax here? |
|
@psakievich Syntax changes are discussed in #44379 (I see a 👍 from you there 😉 ) There's nothing like The To you question on mixed toolchain, the example we have in the issue reads: foo %apple-clang %[virtuals=fortran] gcc |
Sorry. Too many sources of input to keep track of. I'll review and move my comments there. |
Extracted from spack#44419 This adds / modifies some external detection tests for compilers, to reproduce cases that are currently tested in unit tests. The unit tests will later be removed.
|
Superseded by #45784 |
Extracted from spack#44419 This adds / modifies some external detection tests for compilers, to reproduce cases that are currently tested in unit tests. The unit tests will later be removed.
This commit makes:
$ spack compiler findwrite in
packages.yaml, instead ofcompilers.yaml. It also removes dead code after this switch.