Make strong preferences even stronger#44373
Merged
tgamblin merged 1 commit intospack:developfrom May 24, 2024
Merged
Conversation
Before this PR, if Spack could see a possibility to reuse a spec that doesn't match a strong preference, it would do so. After the PR, a strong preference would take precedence.
spackbot-app
bot
added
core
Member
Author
|
Benchmarked on: radiuss.develop.csv
There's a bit of fluctuation, but overall it doesn't seem to affect the average solve time:
|
tgamblin
approved these changes
May 24, 2024
Member
|
Where are the docs? |
Member
Author
|
I didn't document the optimization order (do we need that?). Some docs on strong preferences are here |
alalazo
added a commit
that referenced
this pull request
Jun 5, 2024
Before this PR, if Spack could see a possibility to reuse a spec that doesn't match a strong preference, it would do so. After the PR, a strong preference would take precedence.
teaguesterling
pushed a commit
to teaguesterling/spack
that referenced
this pull request
Jun 15, 2024
Before this PR, if Spack could see a possibility to reuse a spec that doesn't match a strong preference, it would do so. After the PR, a strong preference would take precedence.
haampie
pushed a commit
that referenced
this pull request
Jun 28, 2024
Before this PR, if Spack could see a possibility to reuse a spec that doesn't match a strong preference, it would do so. After the PR, a strong preference would take precedence.
haampie
pushed a commit
that referenced
this pull request
Jul 1, 2024
Before this PR, if Spack could see a possibility to reuse a spec that doesn't match a strong preference, it would do so. After the PR, a strong preference would take precedence.
haampie
pushed a commit
that referenced
this pull request
Jul 1, 2024
Before this PR, if Spack could see a possibility to reuse a spec that doesn't match a strong preference, it would do so. After the PR, a strong preference would take precedence.
hariharan-devarajan
pushed a commit
to hariharan-devarajan/spack
that referenced
this pull request
Jul 10, 2024
Before this PR, if Spack could see a possibility to reuse a spec that doesn't match a strong preference, it would do so. After the PR, a strong preference would take precedence.
3 tasks
alalazo
added a commit
to alalazo/spack
that referenced
this pull request
Aug 26, 2025
fixes spack#51224 In this way trying to solve more input specs is at higher priority than trying to satisfy strong preferences or requirements. This was an unwanted side effect of spack#44373 Signed-off-by: Massimiliano Culpo <[email protected]>
haampie
pushed a commit
that referenced
this pull request
Aug 27, 2025
In this way trying to solve more input specs is at higher priority than trying to satisfy strong preferences or requirements. Fixes a regression introduced by #44373 Signed-off-by: Massimiliano Culpo <[email protected]>
climbfuji
pushed a commit
to climbfuji/spack
that referenced
this pull request
Aug 27, 2025
In this way trying to solve more input specs is at higher priority than trying to satisfy strong preferences or requirements. Fixes a regression introduced by spack#44373 Signed-off-by: Massimiliano Culpo <[email protected]>
alalazo
added a commit
that referenced
this pull request
Sep 8, 2025
In this way trying to solve more input specs is at higher priority than trying to satisfy strong preferences or requirements. Fixes a regression introduced by #44373 Signed-off-by: Massimiliano Culpo <[email protected]>
haampie
pushed a commit
that referenced
this pull request
Sep 12, 2025
In this way trying to solve more input specs is at higher priority than trying to satisfy strong preferences or requirements. Fixes a regression introduced by #44373 Signed-off-by: Massimiliano Culpo <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR, if Spack could see a possibility to reuse a spec that doesn't match a strong preference, it would do so. After the PR, a strong preference would take precedence.