Conversation
|
Hi @robertu94! I noticed that the following package(s) don't yet have maintainers:
Are you interested in adopting any of these package(s)? If so, simply add the following to the package class: maintainers("robertu94")If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with $ spack blame py-langsmithThank you for your help! Please don't add maintainers without their consent. You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer. |
robertu94
force-pushed
the
libpressio-updates-04-24
branch
from
457b7d2 to
464d750
Compare
robertu94
force-pushed
the
libpressio-updates-04-24
branch
from
464d750 to
aa4e61e
Compare
robertu94
force-pushed
the
libpressio-updates-04-24
branch
from
eb1949d to
07943ab
Compare
tldahlgren
left a comment
tldahlgren
left a comment
There was a problem hiding this comment.
Confirmed the new homepages, commits, and all but one sha256. I am also not able to stage the python package to check dependencies though.
I identified several packages with ordering "issues" (e.g., dependencies before variants). There's a FIXME comment that can be removed (poorjit). The rest are suggestions.
robertu94
force-pushed
the
libpressio-updates-04-24
branch
4 times, most recently
from
802b64e to
3f01113
Compare
robertu94
force-pushed
the
libpressio-updates-04-24
branch
from
3f01113 to
c56dcbb
Compare
|
@tldahlgren this is ready for you again when you get time. I understand if you guys are busy with ICS. |
Co-authored-by: Tamara Dahlgren <[email protected]>
|
@tldahlgren I didn't intend to include the py-langsmith change here. That package releases super often, and I just needed a working version for something. I wouldn't have added it to spack, but since it was there I updated it so that it worked for me. |
|
Is this ready to merge or do we still need more changes @tldahlgren ? |
tldahlgren
left a comment
tldahlgren
left a comment
There was a problem hiding this comment.
Re-confirmed commits and sha256s, rest LGTM.
* libpressio update * fix typos in libpressio packages * Addressed review feedback from @tldahlgren * fix ci issues * add missing package for SZx * simplify varient logic and fix GPU deps * Update var/spack/repos/builtin/packages/py-langsmith/package.py --------- Co-authored-by: Robert Underwood <[email protected]> Co-authored-by: Tamara Dahlgren <[email protected]>
* libpressio update * fix typos in libpressio packages * Addressed review feedback from @tldahlgren * fix ci issues * add missing package for SZx * simplify varient logic and fix GPU deps * Update var/spack/repos/builtin/packages/py-langsmith/package.py --------- Co-authored-by: Robert Underwood <[email protected]> Co-authored-by: Tamara Dahlgren <[email protected]>
2 participants
Various updates for the libpressio ecosystem: